refactor: Only test receive, fallback funcs when available

Previously runs all the time, which is currently okay with the current single testing contract that includes both functions. This conditionally adds these test cases if the respective functions exist so we can test additional contract behavior that may not have these functions and may produce a different error.
Kava-Labs · Oct 9, 2024 · 0f248d2 · 0f248d2
1 parent cd15cde
commit 0f248d2
Showing 1 changed file with 27 additions and 18 deletions.
diff --git a/tests/e2e-evm/test/abi_disabled.test.ts b/tests/e2e-evm/test/abi_disabled.test.ts
@@ -95,24 +95,33 @@ describe("ABI_DisabledTests", function () {
       value: bigint;
       data: Hex;
     }
-    const testCases: testCase[] = [
-      { name: "zero value transfer", value: 0n, data: "0x" },
-      { name: "value transfer", value: 1n, data: "0x" },
-      { name: "invalid function selector", value: 0n, data: "0x010203" },
-      { name: "invalid function selector with value", value: 1n, data: "0x010203" },
-      { name: "non-matching function selector", value: 0n, data: toFunctionSelector("does_not_exist()") },
-      { name: "non-matching function selector with value", value: 1n, data: toFunctionSelector("does_not_exist()") },
-      {
-        name: "non-matching function selector with extra data",
-        value: 0n,
-        data: concat([toFunctionSelector("does_not_exist()"), "0x01"]),
-      },
-      {
-        name: "non-matching function selector with value and extra data",
-        value: 1n,
-        data: concat([toFunctionSelector("does_not_exist()"), "0x01"]),
-      },
-    ];
+    const testCases: testCase[] = [];
+
+    if (receiveFunction) {
+      testCases.push(
+        { name: "zero value transfer", value: 0n, data: "0x" },
+        { name: "value transfer", value: 1n, data: "0x" },
+      );
+    }
+
+    if (fallbackFunction) {
+      testCases.push(
+        { name: "invalid function selector", value: 0n, data: "0x010203" },
+        { name: "invalid function selector with value", value: 1n, data: "0x010203" },
+        { name: "non-matching function selector", value: 0n, data: toFunctionSelector("does_not_exist()") },
+        { name: "non-matching function selector with value", value: 1n, data: toFunctionSelector("does_not_exist()") },
+        {
+          name: "non-matching function selector with extra data",
+          value: 0n,
+          data: concat([toFunctionSelector("does_not_exist()"), "0x01"]),
+        },
+        {
+          name: "non-matching function selector with value and extra data",
+          value: 1n,
+          data: concat([toFunctionSelector("does_not_exist()"), "0x01"]),
+        },
+      );
+    }
 
     for (const funcDesc of abi) {
       if (funcDesc.type !== "function") {