Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#890 Suggests tornado no longer needs pinning. #891

Closed
wants to merge 1 commit into from

Conversation

djherbis
Copy link
Contributor

jupyter/notebook#4439 which caused this appears to be fixed

@djherbis djherbis requested review from rosbo and erdalsivri October 22, 2020 16:09
@rosbo
Copy link
Contributor

rosbo commented Oct 22, 2020

@djherbis Have you tested this change in the notebook editor? (note: you can use the admin docker tag feature to test it out).

The jupyter notebook feature is pinned to 5.5.0 (May 2018) and likely won't include the change you are referencing.

We could consider upgrading jupyter but we would need to test that it still work with the styling and all. If we need to update the styling logic, we need to make sure that it will still works for the notebook version 5.5.0 since sessions will still be ran with it.

@djherbis
Copy link
Contributor Author

I missed that we had notebook pinned to 5.5.0 (I had looked for 'juptyer' instead of 'notebook').

I'll still give it a test just to see, but I agree I presume it will still be broken.

@djherbis
Copy link
Contributor Author

Yeah, this is a no-go, jupyter boots but the kernel won't.

@djherbis djherbis closed this Oct 23, 2020
@djherbis
Copy link
Contributor Author

@rosbo I'm actually wondering if unpinning Jupyter might be feasible, we use static assets for jupyter now (not loaded from the actual running jupyter server in Docker), so theoretically none of those should change by unpinning jupyter itself.

@djherbis djherbis mentioned this pull request Oct 23, 2020
@djherbis djherbis deleted the unpin-tornado branch March 4, 2021 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants