-
Notifications
You must be signed in to change notification settings - Fork 969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to tornado 6? #890
Comments
jupyter/notebook#4439 which caused this appears to be fixed
We can certainly try it out, it'll take awhile before it gets released on Kaggle if it does work. @dovahcrow Out of curiosity, what led you to noticing this / how are you using this image? |
Closed my PR trying this out because it seems our pinned jupyter version (5.5.0) still experiences this issue. |
Our library However, |
Yes, you are right. The fix is landed in jupyter 5.7.5 version. |
Yeah these are very fair concerns, I commented on #891 that we might be able to unpin jupyter without consequences, though it'll still take testing/verification. May take some time before we're able to confirm the feasibility. |
Hi @dovahcrow, We have upgraded to Thank you |
Originally, we pinned to tornado 5.0.2 in this commit 72ed33d due to the incompatibility of jupyter with tornado 6 as mentioned in this issue jupyter/notebook#4439.
This bug seems already been fixed in the upstream. Can we relax the requirement now?
The text was updated successfully, but these errors were encountered: