Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to tornado 6? #890

Closed
dovahcrow opened this issue Oct 22, 2020 · 6 comments
Closed

Upgrade to tornado 6? #890

dovahcrow opened this issue Oct 22, 2020 · 6 comments
Assignees
Labels
upgrade-package Requests to update a package to a newer version

Comments

@dovahcrow
Copy link

Originally, we pinned to tornado 5.0.2 in this commit 72ed33d due to the incompatibility of jupyter with tornado 6 as mentioned in this issue jupyter/notebook#4439.

This bug seems already been fixed in the upstream. Can we relax the requirement now?

djherbis added a commit that referenced this issue Oct 22, 2020
@djherbis
Copy link
Contributor

We can certainly try it out, it'll take awhile before it gets released on Kaggle if it does work.

@dovahcrow Out of curiosity, what led you to noticing this / how are you using this image?

@djherbis
Copy link
Contributor

Closed my PR trying this out because it seems our pinned jupyter version (5.5.0) still experiences this issue.

@dovahcrow
Copy link
Author

We can certainly try it out, it'll take awhile before it gets released on Kaggle if it does work.

@dovahcrow Out of curiosity, what led you to noticing this / how are you using this image?

Our library dataprep once had a higher version of tornado. Installing it on the Kaggle Notebook will break the notebook thus making our library not usable on Kaggle. As a workaround, we also pinned tornado in our library.

However, bokeh > 2.0 requires a higher version of tornado. Since bokeh is also a widely used dependency by other libraries, I'm worrying one day this pinned tornado will us impossible to resolve the dependencies. Moreover, I think this pinned tornado will also be an issue for other libraries.

@dovahcrow
Copy link
Author

Closed my PR trying this out because it seems our pinned jupyter version (5.5.0) still experiences this issue.

Yes, you are right. The fix is landed in jupyter 5.7.5 version.

@djherbis
Copy link
Contributor

Yeah these are very fair concerns, I commented on #891 that we might be able to unpin jupyter without consequences, though it'll still take testing/verification.

May take some time before we're able to confirm the feasibility.

@rosbo rosbo self-assigned this Apr 9, 2021
@rosbo rosbo added the upgrade-package Requests to update a package to a newer version label Apr 9, 2021
@rosbo
Copy link
Contributor

rosbo commented Apr 9, 2021

Hi @dovahcrow,

We have upgraded to tornado 6.x in #989. A new image with these changes should be released to Kaggle notebooks in less than two weeks.

Thank you

@rosbo rosbo closed this as completed Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upgrade-package Requests to update a package to a newer version
Projects
None yet
Development

No branches or pull requests

3 participants