Increase spec version for SpaceDock pull requests #254
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #234 the
SpaceDockAdder
gained the ability to submit netkans withfilter_regexp
, butspec_version
was still alwaysv1.4
.In KSP-CKAN/CKAN#3494 we started enforcing the requirement that
spec_version
must bev1.10
or greater forfilter_regexp
.The
SpaceDockAdder
submitted KSP-CKAN/NetKAN#8958 for a mod with a.mdb
file that should be filtered out, sofilter_regexp
was included in theinstall
stanza, and the initial inflation failed:Now the
spec_version
is increased tov1.10
so we can usefilter_regexp
if we need to. I don't think there's any real disadvantage to this even iffilter_regexp
is not used for a particular pull request, since we never made a particular effort to decrease it fromv1.4
to1
when that would have been possible.