Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase spec version for SpaceDock pull requests #254

Merged
merged 1 commit into from
Jan 13, 2022

Conversation

HebaruSan
Copy link
Member

In #234 the SpaceDockAdder gained the ability to submit netkans with filter_regexp, but spec_version was still always v1.4.

In KSP-CKAN/CKAN#3494 we started enforcing the requirement that spec_version must be v1.10 or greater for filter_regexp.

The SpaceDockAdder submitted KSP-CKAN/NetKAN#8958 for a mod with a .mdb file that should be filtered out, so filter_regexp was included in the install stanza, and the initial inflation failed:

image

Now the spec_version is increased to v1.10 so we can use filter_regexp if we need to. I don't think there's any real disadvantage to this even if filter_regexp is not used for a particular pull request, since we never made a particular effort to decrease it from v1.4 to 1 when that would have been possible.

@HebaruSan HebaruSan added Bug Something isn't working SpaceDock Adder Receives indexing requests and generates PRs. labels Jan 13, 2022
@HebaruSan HebaruSan merged commit 5fb9275 into KSP-CKAN:master Jan 13, 2022
@HebaruSan HebaruSan deleted the fix/adder-spec-version branch January 13, 2022 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working SpaceDock Adder Receives indexing requests and generates PRs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant