Filter out clutter files in SD PRs #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Neat! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
After #233, I remembered that @linuxgurugamer had also submitted KSP-CKAN/NetKAN#5178, so I decided to mine it for ideas. It mentions automatic
filterandfilter_regexpproperty generation based on ZIP contents and special handling forShipsfolders.Changes
Now the
ModAnalyzerscans the ZIP to see if any of its files match several common filters, which I determined by looking at all the filters currently present in the NetKAN repo. If so, the install stanza is modified to filter them out. This should take another small bit of work off the hands of maintainers.Shipsfolders are not handled specially, because there's too much variation in how authors treat those folders to handle them automatically, and we have an inflator warning for that already anyway (see KSP-CKAN/CKAN#3207).I'm planning to self-review this since it's mainly for me anyway.