-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for cross-chain switch reversal #744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntn-x2
force-pushed
the
aa/transfer-revert
branch
2 times, most recently
from
October 3, 2024 10:02
d6289fa
to
e9a4c1a
Compare
Ad96el
reviewed
Oct 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments alongside the offline discussion about the query Id
Ad96el
approved these changes
Oct 8, 2024
ntn-x2
force-pushed
the
aa/transfer-revert
branch
from
October 8, 2024 15:35
eaf2922
to
cb42bbb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/KILTprotocol/ticket/issues/3625.
Description
Matcher
implementation to work. The matcher should not really care about that. All other XCM components have not changed.switch
, or when receiving a query response, which deletes entries from the map, as defined by theOnResponse
implementation of the pallet itself.OnResponse
implementation.runtime-common
andkilt-support
.I will refactor the code in a different PR, where I will also tackle https://github.com/KILTprotocol/ticket/issues/3628.
How to test
You can run a Chopsticks environment, set up a switch pair, and try to do a switch for an account that has enough KILTs but has no ED on AssetHub. The operation will eventually fail and the transfer will be reverted back on KILT. A revert event is generated.
You can also test a correct transfer, which will behave as before, while removing the pending transfer storage entry and generating an event for the transfer finalization.
TODO