Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: runtime API for switch XCM #746

Merged
merged 23 commits into from
Oct 10, 2024
Merged

feat: runtime API for switch XCM #746

merged 23 commits into from
Oct 10, 2024

Conversation

ntn-x2
Copy link
Member

@ntn-x2 ntn-x2 commented Oct 8, 2024 •
edited
Loading

Fixes https://github.com/KILTprotocol/ticket/issues/3628.

  • Moves most of the versioned -> v4 logic into a TryFrom implementation
  • Moves the XCM message creation into its own function
  • Re-use the function in a new runtime API method for the switch pallet

@ntn-x2 ntn-x2 changed the base branch from develop to aa/transfer-revert October 8, 2024 12:15
@ntn-x2 ntn-x2 force-pushed the aa/polar-path-refactor branch from e3e1bb3 to dc7aae9 Compare October 8, 2024 14:26
@ntn-x2 ntn-x2 marked this pull request as ready for review October 8, 2024 15:21
@ntn-x2 ntn-x2 requested a review from Ad96el October 8, 2024 15:21
@ntn-x2 ntn-x2 force-pushed the aa/transfer-revert branch from eaf2922 to cb42bbb Compare October 8, 2024 15:35
Base automatically changed from aa/transfer-revert to develop October 8, 2024 15:35
@ntn-x2 ntn-x2 force-pushed the aa/polar-path-refactor branch from 282119f to a8b1dc9 Compare October 8, 2024 15:36
Ad96el
Ad96el reviewed Oct 9, 2024
View reviewed changes
Copy link
Member

@Ad96el Ad96el left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor comments

pallets/pallet-asset-switch/src/lib.rs Outdated Show resolved Hide resolved
pallets/pallet-asset-switch/src/lib.rs Show resolved Hide resolved
@ntn-x2 ntn-x2 force-pushed the aa/polar-path-refactor branch from 53b5184 to e1f0c57 Compare October 9, 2024 08:00
@ntn-x2 ntn-x2 merged commit 1dfd32f into develop Oct 10, 2024
5 of 7 checks passed
@ntn-x2 ntn-x2 deleted the aa/polar-path-refactor branch October 10, 2024 07:48
ntn-x2 added a commit that referenced this pull request Oct 10, 2024
@ntn-x2
Revert "feat: runtime API for switch XCM (#746)"
9a9728c 
This reverts commit 1dfd32f.
ntn-x2 added a commit that referenced this pull request Oct 10, 2024
@ntn-x2
Revert "feat: runtime API for switch XCM (#746)"
8b7d859 
This reverts commit 1dfd32f.
ntn-x2 added a commit that referenced this pull request Oct 10, 2024
@ntn-x2
Revert "feat: runtime API for switch XCM (#746)"
01f1b26 
This reverts commit 1dfd32f.
ntn-x2 added a commit that referenced this pull request Oct 11, 2024
@ntn-x2
Revert "feat: runtime API for switch XCM (#746)"
f33b679 
This reverts commit 1dfd32f.
ntn-x2 added a commit that referenced this pull request Oct 11, 2024
@ntn-x2
Revert "feat: runtime API for switch XCM (#746)"
0e0a0c5 
This reverts commit 1dfd32f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ad96el Ad96el Ad96el approved these changes

Assignees
No one assigned
Labels
❄️ Polar Path
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ntn-x2 @Ad96el