Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

show: skip useless type-aliases #38099

Merged
merged 1 commit into from
Oct 20, 2020
Merged

show: skip useless type-aliases #38099

merged 1 commit into from
Oct 20, 2020

Conversation

vtjnash
Copy link
Member

@vtjnash vtjnash commented Oct 19, 2020

Fixes #38077

@JeffBezanson JeffBezanson added the display and printing Aesthetics and correctness of printed representations of objects. label Oct 19, 2020
@vtjnash vtjnash merged commit 6b00c24 into master Oct 20, 2020
@vtjnash vtjnash deleted the jn/38077 branch October 20, 2020 16:39
vtjnash added a commit that referenced this pull request Feb 18, 2021
@vtjnash
ensure to show the whole type, even if the proper subset matched an a…
b729667 
…lias

This code should only have been active for make_typealiases, but #38099
already fixed that better, so we can just remove this now.

Fixes #39723
KristofferC pushed a commit that referenced this pull request Feb 22, 2021
@vtjnash @KristofferC
ensure to show the whole type, even if the proper subset matched an a…
dcc2a2d 
…lias

This code should only have been active for make_typealiases, but #38099
already fixed that better, so we can just remove this now.

Fixes #39723

(cherry picked from commit b729667)
ElOceanografo pushed a commit to ElOceanografo/julia that referenced this pull request May 4, 2021
@vtjnash @ElOceanografo
ensure to show the whole type, even if the proper subset matched an a…
dfddd66 
…lias

This code should only have been active for make_typealiases, but JuliaLang#38099
already fixed that better, so we can just remove this now.

Fixes JuliaLang#39723
antoine-levitt pushed a commit to antoine-levitt/julia that referenced this pull request May 9, 2021
@vtjnash @antoine-levitt
ensure to show the whole type, even if the proper subset matched an a…
153295c 
…lias

This code should only have been active for make_typealiases, but JuliaLang#38099
already fixed that better, so we can just remove this now.

Fixes JuliaLang#39723
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
@vtjnash @staticfloat
ensure to show the whole type, even if the proper subset matched an a…
a3c3286 
…lias

This code should only have been active for make_typealiases, but #38099
already fixed that better, so we can just remove this now.

Fixes #39723

(cherry picked from commit b729667)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
display and printing Aesthetics and correctness of printed representations of objects.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

confusing printing of Union{Number, AbstractChar}
2 participants
@vtjnash @JeffBezanson