Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

error in printing method signatures with Unions and type parameters #39723

Closed
BioTurboNick opened this issue Feb 18, 2021 · 0 comments · Fixed by #39728
Closed

error in printing method signatures with Unions and type parameters #39723

BioTurboNick opened this issue Feb 18, 2021 · 0 comments · Fixed by #39728
Assignees
@vtjnash
Labels
display and printing Aesthetics and correctness of printed representations of objects.

Comments

@BioTurboNick
Copy link
Contributor

Method signatures with certain Union types aren't printed correctly.

foo(::Union{AbstractVector{T}, T}) where T = nothing
methods(foo)

Julia 1.5.3:

# 1 method for generic function "foo":
[1] foo(::Union{AbstractArray{T,1}, T}) where T in Main at REPL[1]:1

Julia 1.6.0-rc-1

# 1 method for generic function "foo":
[1] foo(::AbstractVector{T}) where T in Main at REPL[1]:1
@vtjnash vtjnash self-assigned this Feb 18, 2021
vtjnash added a commit that referenced this issue Feb 18, 2021
@vtjnash
ensure to show the whole type, even if the proper subset matched an a…
b729667 
…lias

This code should only have been active for make_typealiases, but #38099
already fixed that better, so we can just remove this now.

Fixes #39723
@vtjnash vtjnash mentioned this issue Feb 18, 2021
Merged
@JeffBezanson JeffBezanson added the display and printing Aesthetics and correctness of printed representations of objects. label Feb 18, 2021
@vtjnash vtjnash changed the title [release-1.6] Error in printing method signatures with Unions and type parameters error in printing method signatures with Unions and type parameters Feb 22, 2021
KristofferC pushed a commit that referenced this issue Feb 22, 2021
@vtjnash @KristofferC
ensure to show the whole type, even if the proper subset matched an a…
dcc2a2d 
…lias

This code should only have been active for make_typealiases, but #38099
already fixed that better, so we can just remove this now.

Fixes #39723

(cherry picked from commit b729667)
ElOceanografo pushed a commit to ElOceanografo/julia that referenced this issue May 4, 2021
@vtjnash @ElOceanografo
ensure to show the whole type, even if the proper subset matched an a…
dfddd66 
…lias

This code should only have been active for make_typealiases, but JuliaLang#38099
already fixed that better, so we can just remove this now.

Fixes JuliaLang#39723
antoine-levitt pushed a commit to antoine-levitt/julia that referenced this issue May 9, 2021
@vtjnash @antoine-levitt
ensure to show the whole type, even if the proper subset matched an a…
153295c 
…lias

This code should only have been active for make_typealiases, but JuliaLang#38099
already fixed that better, so we can just remove this now.

Fixes JuliaLang#39723
staticfloat pushed a commit that referenced this issue Dec 23, 2022
@vtjnash @staticfloat
ensure to show the whole type, even if the proper subset matched an a…
a3c3286 
…lias

This code should only have been active for make_typealiases, but #38099
already fixed that better, so we can just remove this now.

Fixes #39723

(cherry picked from commit b729667)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vtjnash vtjnash

Labels
display and printing Aesthetics and correctness of printed representations of objects.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ensure to show the whole type, even if the proper subset matched an alias JuliaLang/julia
3 participants
@vtjnash @JeffBezanson @BioTurboNick