-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Expr(:simdloop)
to Expr(:loopinfo, ...)
#31095
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@nanosoldier |
- `Expr(:loopinfo, Symbol("julia.simdloop"))` replaces `Expr(:simdloop, false)` - `Expr(:loopinfo, Symbol("julia.simdloop"), Symbol("julia.ivdep"))` replaces `Expr(:simdloop, true)` While currently not directly exposed users can now pass other [loopinfo](https://llvm.org/docs/LangRef.html#llvm-loop) metadata to LLVM.
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan |
Nanosoldier seems fine (if this would lead to failed vectorisation I would expect slow downs on the oder of 4x) @Keno good to merge or so you have comments about the current implementation? |
Fine with me. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expr(:loopinfo, Symbol("julia.simdloop"))
replacesExpr(:simdloop, false)
Expr(:loopinfo, Symbol("julia.simdloop"), Symbol("julia.ivdep"))
replacesExpr(:simdloop, true)
While currently not directly exposed, users can now pass other loopinfo metadata to LLVM.
Codegen attaches the loop metadata to the call to the marker and the
LowerSIMD
pass consumes that metadata andattaches it to the loop.
I needed this for #31086, this also removes unneeded and untested machinery from
llvm-simdloop.cpp
.