Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix on julia master #134

Merged
merged 1 commit into from
Mar 13, 2019
Merged

fix on julia master #134

merged 1 commit into from
Mar 13, 2019

Conversation

KristofferC
Copy link
Member

@codecov-io
Copy link

codecov-io commented Mar 13, 2019 •
edited
Loading

Codecov Report

Merging #134 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #134   +/-   ##
=====================================
  Coverage       0%     0%           
=====================================
  Files          14     14           
  Lines        1630   1630           
=====================================
  Misses       1630   1630
Impacted Files Coverage Δ
src/interpret.jl 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9191196...6e949ca. Read the comment docs.

@KristofferC KristofferC merged commit b96c37e into master Mar 13, 2019
@KristofferC KristofferC deleted the kc/julia_master branch March 13, 2019 14:40
vchuravy
vchuravy reviewed Mar 15, 2019
View reviewed changes
src/interpret.jl
@@ -353,7 +353,8 @@ function eval_rhs(@nospecialize(recurse), frame, node::Expr)
return length(frame.framedata.exception_frames)
elseif head == :boundscheck
return true
elseif head == :meta || head == :inbounds || head == :simdloop || head == :gc_preserve_begin || head == :gc_preserve_end
elseif head == :meta || head == :inbounds || head == (@static VERSION >= v"1.2.0-DEV.462" ? :loopinfo : :simdloop) ||
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe use is_meta_expr_head in Base.Meta?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vchuravy vchuravy vchuravy left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KristofferC @codecov-io @vchuravy