Use tarballs instead of git checkouts by default for git-externals deps #15724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 1, 2016
|
@vtjnash are you okay with switching this? If you want to work on libuv or openlibm often then you should set this flag but be prepared to have to clean out libgit2 or openblas when we need patches. A more specific fix just for those 2 would also work but be a bigger change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the condition on git-externals from depending on
NO_GITand defaulting to a clone, to depending on a new variableDEPS_GITwhich you have to set to 1 to keep the current behavior. Now defaults to tarballs.