-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use fewer processes while building OpenBLAS #15720
Conversation
@@ -1185,6 +1185,7 @@ OPENBLAS_BUILD_OPTS += NO_AVX2=1 | |||
endif | |||
|
|||
$(BUILDDIR)/$(OPENBLAS_SRC_DIR)/config.status: $(BUILDDIR)/$(OPENBLAS_SRC_DIR)/Makefile | |||
cd $(dir $@) && patch -p1 < ../openblas-make.patch | |||
ifeq ($(OS),WINNT) | |||
cd $(dir $@) && patch -p1 < $(SRCDIR)/openblas-win64.patch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you'll have to delete this patch, and update the checksums if we're going to update to 0.2.17
6d4c19e
to
97d5404
Compare
|
97d5404
to
759102f
Compare
Thanks for the pointer to these other checksums. |
Note that we should probably merge this in very close succession with #15724 if we want to do both of them, since either in isolation will cause an openblas rebuild. (so will merging both close together, but at least it'll be a single rebuild instead of two) |
upstream merged patch in OpenMathLib/OpenBLAS#829 was a little different, uses a different flag name |
@tkelman We can apply the patch nonetheless; once a new version of OpenBLAS is released, we will remove our patch anyway. |
But the upstream patch uses a different name for the make flag. So we'd need to change. Let's use a patch that matches what we will get from upstream so the flag can match as well. |
759102f
to
42d13b4
Compare
Now using the upstream commit as patch. |
Cool. I'm okay with this version, but for the sake of not making everyone rebuild openblas twice let's see if there are any objections to #15724. |
Closes #15716