Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fewer processes while building OpenBLAS #15720

Merged
merged 1 commit into from
Apr 2, 2016

Conversation

eschnett
Copy link
Contributor

Closes #15716

@@ -1185,6 +1185,7 @@ OPENBLAS_BUILD_OPTS += NO_AVX2=1
endif

$(BUILDDIR)/$(OPENBLAS_SRC_DIR)/config.status: $(BUILDDIR)/$(OPENBLAS_SRC_DIR)/Makefile
cd $(dir $@) && patch -p1 < ../openblas-make.patch
ifeq ($(OS),WINNT)
cd $(dir $@) && patch -p1 < $(SRCDIR)/openblas-win64.patch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you'll have to delete this patch, and update the checksums if we're going to update to 0.2.17

@eschnett eschnett force-pushed the eschnett/openblas-make branch 2 times, most recently from 6d4c19e to 97d5404 Compare April 1, 2016 01:29
@tkelman
Copy link
Contributor

tkelman commented Apr 1, 2016

make -C deps NO_GIT=1 configure-openblas && git rm -r deps/checksums/openblas-53e849f4fcae4363a64576de00e982722c7304f9.tar.gz && git add deps/checksums/openblas-a71e8c82f6a9f73093b631e5deab1e8da716b61f.tar.gz

@eschnett eschnett force-pushed the eschnett/openblas-make branch from 97d5404 to 759102f Compare April 1, 2016 02:15
@eschnett
Copy link
Contributor Author

eschnett commented Apr 1, 2016

Thanks for the pointer to these other checksums.

@tkelman
Copy link
Contributor

tkelman commented Apr 1, 2016

Note that we should probably merge this in very close succession with #15724 if we want to do both of them, since either in isolation will cause an openblas rebuild. (so will merging both close together, but at least it'll be a single rebuild instead of two)

@tkelman
Copy link
Contributor

tkelman commented Apr 1, 2016

upstream merged patch in OpenMathLib/OpenBLAS#829 was a little different, uses a different flag name

@eschnett
Copy link
Contributor Author

eschnett commented Apr 1, 2016

@tkelman We can apply the patch nonetheless; once a new version of OpenBLAS is released, we will remove our patch anyway.

@tkelman
Copy link
Contributor

tkelman commented Apr 1, 2016

But the upstream patch uses a different name for the make flag. So we'd need to change. Let's use a patch that matches what we will get from upstream so the flag can match as well.

@eschnett eschnett force-pushed the eschnett/openblas-make branch from 759102f to 42d13b4 Compare April 1, 2016 17:51
@eschnett
Copy link
Contributor Author

eschnett commented Apr 1, 2016

Now using the upstream commit as patch.

@tkelman
Copy link
Contributor

tkelman commented Apr 2, 2016

Cool. I'm okay with this version, but for the sake of not making everyone rebuild openblas twice let's see if there are any objections to #15724.

@tkelman tkelman merged commit 7f177aa into JuliaLang:master Apr 2, 2016
tkelman pushed a commit that referenced this pull request Jun 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants