Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new DFT api #12201

Merged
merged 1 commit into from
Jul 18, 2015
Merged

new DFT api #12201

merged 1 commit into from
Jul 18, 2015

Conversation

yuyichao
Copy link
Contributor

This is a pure rebase of #12087. The plan is described in #12087 (comment) .

This PR is only for rebasing and getting a full CI run. Will merge after that.

@yuyichao
Copy link
Contributor Author

I know the AppVeyor has to fail just before I want to merge it! No matter how many times it has passed in a row before that....

So we've got a new pattern in the windows CI failure?

ERROR: syntax: invalid escape sequence
jl_uv_writecb() ERROR: broken pipe EPIPE

@ViralBShah
Copy link
Member

Is it ok to ignore appveyor then?

@yuyichao
Copy link
Contributor Author

I'm tempting.

@yuyichao
Copy link
Contributor Author

Looking at the AppVeyor history, it's not like that the freeze hasn't happen on recent commits before this PR so I think I'm going to merge this and give Tony an hour or two to stop me.....

yuyichao added a commit that referenced this pull request Jul 18, 2015
@yuyichao yuyichao merged commit 45f9cc5 into master Jul 18, 2015
@yuyichao yuyichao deleted the yyc/dftnew branch July 18, 2015 14:11
@tkelman
Copy link
Contributor

tkelman commented Jul 19, 2015

Looks like you restarted it, where was the freeze occurring? If it was the spawn test, yes that still happens intermittently, but it's best to restart the run if the queue's not too long to verify that it's not some new failure mode.

@yuyichao
Copy link
Contributor Author

@tkelman Yes it was freezing after printing the error message I pasted above in the spawn test.

@tkelman
Copy link
Contributor

tkelman commented Jul 19, 2015

Though judging by your comment in #12144 that may have actually been an unrelated warning

@yuyichao
Copy link
Contributor Author

The warning first appears after #12144 and I think is unrelated.

Edit: somehow missed that you already mentioned #12144...

@yuyichao
Copy link
Contributor Author

#12144 (comment)

@esd100
Copy link

esd100 commented Jul 22, 2015

I'm just curious if you guys have heard of the extended DFT (http://arxiv.org/abs/1303.2033)? After perusing his thesis summary, it sounds like we should be moving toward this type of more accurate math and away from the approximations we would make to reduce total flops or increase the speed of the calculation. It only makes sense in light of the fact that the speed of processors increases by orders of magnitude every few years.

@pao
Copy link
Member

pao commented Jul 22, 2015

@esd100 Note that this issue is just about updating the API for the existing functionality, and not adding new DFT features. Even then, that's an open-ended question better suited for mailing list discussion.

simonster added a commit to JuliaDSP/DSP.jl that referenced this pull request Jul 28, 2015
JuliaLang/julia#12201 (new DFT API)
JuliaLang/julia@189a043 (require no longer necessary in tests)
tkelman added a commit that referenced this pull request Mar 16, 2017
FFTW wrappers were moved and mostly rewritten - the Julia wrappers
are probably not GPL? ref 481f351
and #8248 and #12201

make note of grisu derived license in top-level LICENSE.md
and update links, repo was moved from github.com/floitsch to github.com/google

umfpack and cholmod code were moved from base/linalg to base/sparse
@iamnapo iamnapo mentioned this pull request Apr 5, 2017
KristofferC pushed a commit to JuliaAttic/Grisu.jl that referenced this pull request Sep 21, 2020
FFTW wrappers were moved and mostly rewritten - the Julia wrappers
are probably not GPL? ref JuliaLang/julia@481f351
and JuliaLang/julia#8248 and JuliaLang/julia#12201

make note of grisu derived license in top-level LICENSE.md
and update links, repo was moved from github.com/floitsch to github.com/google

umfpack and cholmod code were moved from base/linalg to base/sparse
vchuravy pushed a commit to JuliaPackaging/LazyArtifacts.jl that referenced this pull request Oct 2, 2023
FFTW wrappers were moved and mostly rewritten - the Julia wrappers
are probably not GPL? ref JuliaLang/julia@6bd4f15
and JuliaLang/julia#8248 and JuliaLang/julia#12201

make note of grisu derived license in top-level LICENSE.md
and update links, repo was moved from github.com/floitsch to github.com/google

umfpack and cholmod code were moved from base/linalg to base/sparse
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants