Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compat for JuliaLang/julia#12472 #130

Merged
merged 1 commit into from
Aug 11, 2015
Merged

compat for JuliaLang/julia#12472 #130

merged 1 commit into from
Aug 11, 2015

Conversation

stevengj
Copy link
Member

This adds the new isapprox array functions and binary operators from JuliaLang/julia#12472.

It also added the new real(T) methods from JuliaLang/julia#12201, which were needed for rtoldefault.

I also needed to fix JuliaLang/julia#121 by adding AbstractFloat

@stevengj
Copy link
Member Author

Failure on 0.3 seems related to JuliaLang/LinearAlgebra.jl#236

@stevengj
Copy link
Member Author

Actually, failure on 0.3 is because of 12552 combined with norm([0,Inf]) == NaN on 0.3 (== Inf on 0.4). I think I should just remove this test case and accept that isapprox may behave badly for Inf in 0.3 (since even if fixes to norm and max are backported, they won't apply to older 0.3 versions).

add AbstractFloat (fix #121)
stevengj added a commit that referenced this pull request Aug 11, 2015
@stevengj stevengj merged commit 74cea69 into master Aug 11, 2015
@stevengj stevengj deleted the isapprox branch August 11, 2015 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Speeding up copy()
1 participant