Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify role of constants in preparation #485

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Clarify role of constants in preparation #485

merged 1 commit into from
Sep 23, 2024

Conversation

gdalle
Copy link
Member

@gdalle gdalle commented Sep 23, 2024

DI source

  • Specify in Constant docstring that the constant's value shouldn't change after same-point preparation has been performed

DI extensions

  • Only allow Zygote to accept Constants and not general Contexts

@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.51%. Comparing base (ee11b70) to head (b201d33).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #485   +/-   ##
=======================================
  Coverage   98.51%   98.51%           
=======================================
  Files         107      107           
  Lines        4298     4298           
=======================================
  Hits         4234     4234           
  Misses         64       64           
Flag Coverage Δ
DI 98.57% <100.00%> (ø)
DIT 98.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle linked an issue Sep 23, 2024 that may be closed by this pull request
@gdalle gdalle merged commit 5750b31 into main Sep 23, 2024
54 of 60 checks passed
@gdalle gdalle deleted the gd/constzyg branch September 24, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preparation with constants
2 participants