Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preparation with constants #475

Closed
gdalle opened this issue Sep 19, 2024 · 0 comments · Fixed by #485
Closed

Preparation with constants #475

gdalle opened this issue Sep 19, 2024 · 0 comments · Fixed by #485
Labels
backend Related to one or more autodiff backends bug Something isn't working
Milestone
v0.6

Comments

@gdalle
Copy link
Member

gdalle commented Sep 19, 2024 •
edited
Loading

The pullback cannot be precomputed for same-point preparation if the constant changes!
It's probably reasonable to interpret same_point as "same x and same contexts".

Correctness testing needs to change the contexts.
@gdalle gdalle added bug Something isn't working backend Related to one or more autodiff backends labels Sep 19, 2024
@gdalle gdalle added this to the v0.6 milestone Sep 19, 2024
@gdalle gdalle changed the title Fix contexts for Zygote Preparation with constants Sep 19, 2024
@gdalle gdalle linked a pull request Sep 23, 2024 that will close this issue
Clarify role of constants in preparation #485
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backend Related to one or more autodiff backends bug Something isn't working
Projects
None yet
Milestone
v0.6
Development

Successfully merging a pull request may close this issue.

Clarify role of constants in preparation JuliaDiff/DifferentiationInterface.jl
1 participant
@gdalle