Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error in constructor #82

Merged
merged 3 commits into from
Apr 30, 2022
Merged

Fix error in constructor #82

merged 3 commits into from
Apr 30, 2022

Conversation

bkamins
Copy link
Member

@bkamins bkamins commented Apr 28, 2022

Fixes 2 errors:

  • access to #undef
  • wrong handling of non 1-based source arrays

@bkamins bkamins requested a review from nalimilan April 28, 2022 10:23
@bkamins bkamins added the bug label Apr 28, 2022
@codecov
Copy link

codecov bot commented Apr 28, 2022 •
edited
Loading

Codecov Report

Merging #82 (e68e394) into main (d84c4be) will increase coverage by 0.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #82      +/-   ##
==========================================
+ Coverage   89.12%   89.22%   +0.09%     
==========================================
  Files           1        1              
  Lines         331      334       +3     
==========================================
+ Hits          295      298       +3     
  Misses         36       36
Impacted Files Coverage Δ
src/PooledArrays.jl 89.22% <100.00%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d84c4be...e68e394. Read the comment docs.

nalimilan
nalimilan approved these changes Apr 29, 2022
View reviewed changes
test/runtests.jl Show resolved Hide resolved
test/runtests.jl Show resolved Hide resolved
@bkamins @nalimilan
Apply suggestions from code review
e68e394 
Co-authored-by: Milan Bouchet-Valat <nalimilan@club.fr>
@bkamins bkamins mentioned this pull request Apr 29, 2022
Merged
@bkamins bkamins merged commit 65e3316 into main Apr 30, 2022
@bkamins bkamins deleted the bk/fix_constructor branch April 30, 2022 06:20
@bkamins
Copy link
Member Author

bkamins commented Apr 30, 2022

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nalimilan nalimilan nalimilan approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bkamins @nalimilan