Fix handling of variable_eltype in stack #3043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nalimilan
reviewed
Apr 29, 2022
src/abstractdataframe/reshape.jl
Outdated
Comment on lines
167
to
168
| catnms = simnms isa Vector ? PooledArray(catnms) : simnms | ||
| copyto!(catnms, nms) | ||
| copyto!(simnms, nms) | ||
| catnms = simnms isa Vector ? PooledArray(simnms) : simnms |
There was a problem hiding this comment.
Why call copyto!(simnms, nms) rather than copyto!(catnms, nms) later? Wouldn't the latter be faster?
There was a problem hiding this comment.
Without JuliaData/PooledArrays.jl#82 released this will not work. After I make a release of PooledArrays.jl I will make this change.
There was a problem hiding this comment.
I have changed this as indeed it is slightly faster. Here using copyto! should be safe as we know nms cannot have #undef so we are not affected by JuliaLang/julia#45125.
Co-authored-by: Milan Bouchet-Valat <nalimilan@club.fr>
nalimilan
approved these changes
May 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3042.
@nalimilan - I will make a patch release after this PR is merged