-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update "Set default branch explicitly" #316
Update "Set default branch explicitly" #316
Conversation
Since the one in WackyOptions is now GitHubActions to test `deploybranch`.
d04f3bd
to
60b3f06
Compare
Codecov Report
@@ Coverage Diff @@
## master #316 +/- ##
==========================================
+ Coverage 94.32% 94.75% +0.42%
==========================================
Files 20 20
Lines 617 610 -7
==========================================
- Hits 582 578 -4
+ Misses 35 32 -3
Continue to review full report at Codecov.
|
db4f3bd
to
1241232
Compare
This is finally passing. |
1241232
to
56a9b40
Compare
The transition from SimpleMocking to Mocking occurred after this PR was initially submitted.
56a9b40
to
fe008fb
Compare
I believe I have fixed all the weirdnesses; my changes are limited to a single commit (the last). Short, easy to review. Can we merge this and register a new release? In about 10 days I will be teaching a class to Julia newbies, and I'd really rather not have to write a whole page of documentation about how to manually update all dangling references from |
Yes, this LGTM, but i've not had time to review in depth. @mjram0s do you happen to have time to take a quick look? Either way, i will merge and register a new version this evening :) |
And thank you so much for taking this on, @timholy! |
I can take a look at this today! |
Co-authored-by: Mary Jo Ramos <maryjoramos@gmail.com>
@mjram0s, can we do a 1.5->1.6 update later? I'm not sure what's going on but clearly it's not a 2-line fix; there are slightly different Manifest files loaded on different Julia versions; I don't think there's anything fundamental going on here, it's just all dumb bookkeeping differences that I lack the time to track down now. I'm going to revert the last couple of commits on this branch. |
Thanks again, Tim! I'll register a new version now Update the tests from 1.5 -> 1.6 involves a bit of work, but you're absolutely right MJ that we're overdue doing it! #313 |
Thanks for finishing this up for me! ❤️ |
You did all the hard work, my contribution ended up being a few lines. And I learned a bit (just a bit...) about the internals of an important package for the ecosystem. Thanks again for everything you've done for this package! |
#243 seems like an important change. This is my attempt to bring it up to date. This seems reasonable now.