-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set default branch explicitly #243
Conversation
Codecov Report
@@ Coverage Diff @@
## master #243 +/- ##
==========================================
- Coverage 82.18% 0.67% -81.52%
==========================================
Files 19 19
Lines 612 594 -18
==========================================
- Hits 503 4 -499
- Misses 109 590 +481
Continue to review full report at Codecov.
|
c0875e7
to
dcc6287
Compare
Since the one in WackyOptions is now GitHubActions to test `deploybranch`.
dcc6287
to
5ce493d
Compare
bump :) |
I would love to see this PR merged soon. Specifically, I'm preparing a tutorial and noticed that |
If anyone has time to take over, they should feel free -- I currently do not, unfortunately. |
I could try to understand and fix this PR, but it is massive, and I don't know the project well enough. So I would probably just get frustrated along the way. By the way, my concern here is that I'm using |
Superseded by #316, please close (I forgot to put that in my PR OP). |
Closes #233
The
Git
plugin will set the default branch with the following priority:branch
keyword to theGit
constructorinit.defaultBranch
"main"
And all the other plugins can use that where they need to refer to the default branch.
This needs the
default_branch
from #242.This adds a bit of awkwardness for testing with preexisting Git configurations that set
init.defaultBranch
to something other thanmain
, since a bunch of tests assume that it'll be unset. I addedwith_clean_gitconfig
to sort of solve that, but the mocking is too slow to use on the reference tests so they're just disabled in that case.