Fix iteration over Axis #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Iterate over elements in the Axis instead of just returning the axis. Is in line
with `axes(Ax) = OneTo(<length of elems>)` and `length(Ax) = <length of elems>`.
Also add `Iterator{Size,Eltype}` traits.
No tests are broken (that worked before).
3 tasks
|
Before the transition to 0.7, I would like to fix that by, either
What's the next steps? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Iterate over elements in the Axis instead of just returning the axis. Is in line with
axes(Ax) = OneTo(<length of elems>)andlength(Ax) = <length of elems>.Also add
Iterator{Size,Eltype}traits.No tests are broken (that worked before).
Does this make sense?