Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Julia 1.1 and JuMP 0.19 (ie. MOI) #1

Closed
2 of 3 tasks
coroa opened this issue May 27, 2019 · 2 comments
Closed
2 of 3 tasks

Update to Julia 1.1 and JuMP 0.19 (ie. MOI) #1

coroa opened this issue May 27, 2019 · 2 comments

Comments

@coroa
Copy link
Member

coroa commented May 27, 2019

  • Julia 1.1 code
  • Replace AxisArray with JuMP's DenseAxisArray
  • Re-do @emvariable, @emconstraint macros based on macrocall
@coroa
Copy link
Member Author

coroa commented May 31, 2019

DenseAxisArray does not have names for its axes, so that WrappedArray cannot be used to augment the Array automatically. On the other hand will the compilation overhead probably decrease since the type information does change less often :).

Three possible solutions:

  1. The current code based AxisArrays works again, with a small one line modification that makes Axis types iterable again (Fix iteration over Axis JuliaArrays/AxisArrays.jl#160).

  2. We could easily push the axes augmentation into get(::Data, ...), where the axes info is still known from the NetCDF itself.

@coroa
Copy link
Member Author

coroa commented Jun 4, 2019

Fixed by 31d13df.

@coroa coroa closed this as completed Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant