Implemented about dialog in Java FX #968

boceckts · 2016-03-15T09:14:42Z

This is the first dialog in JabRef being implemented in JavaFX. The Dialog is highly flexible in positioning and styling its components through a fxml and corresponding css stylesheet. If JavaFX should be a part of JabRef it is probabbly usefull to define a global stylesheet as well to become a consistent look and feel.
To include JavaFX in JabRef I had to adjust the starting and closing behaviour of Jabref.

In order to run these commits, Java 8_40 or newer is required!

Change in CHANGELOG.md described?
Changes in pull request outlined? (What, why, ...)
Tests created for changes?
Tests green?

simonharrer · 2016-03-15T09:23:48Z

Travis CI uses Jdk 1.8.0_31, and because of this cannot compile this.

boceckts · 2016-03-15T09:32:14Z

As it says in the error message the class javafx.scene.control.Alert can not be found since this has been introduced in Java 8_40 along with javafx.scene.control.Dialog. However this is a essential part in creating a javafx gui since it is basically the equivalent class to JOptionPane / JDialog classes in swing.
Is it possible to update the jdk version of the Travis CI?

simonharrer · 2016-03-15T09:34:31Z

Please do investigate on this.

Siedlerchr · 2016-03-15T09:57:09Z

@boceckts This is currently a problem with Travis,but it can be updated:
travis-ci/travis-ci#3259

This one looks the most promising:
travis-ci/travis-ci#3259 (comment)

tobiasdiez · 2016-03-15T10:56:01Z

src/main/java/net/sf/jabref/gui/help/AboutDialogController.java

+
+        closeButton.setText(Localization.lang("Close"));
+
+        copyButton.setText(Localization.lang("Copy_version_to_clipboard"));


Just use normal spaces instead of underscore. Then the circleci test should pass.

koppor · 2016-03-15T15:33:30Z

@boceckts As JabRef uses both CircleCI and Travis and tests for both OpenJDK and JRE, there won't be a simple solution.

Siedlerchr · 2016-03-15T15:57:00Z

For cicle CI
Higher jdk versions than Build 25 (this was from one blog post) seem to be not available, a workaound seems to be this hack:
https://discuss.circleci.com/t/java-version/2435

Edit// This one here for installing new version of qt5 seems to be related/similar:
https://discuss.circleci.com/t/using-qt-5-with-circleci/88

boceckts · 2016-03-15T16:08:28Z

Thank you for all your feedback, I'm goinig to further investigate on this.

tschechlovdev · 2016-03-16T12:43:47Z

src/main/java/net/sf/jabref/gui/JabRefFrame.java

+            try (InputStream imageStream = JabRef.class.getResourceAsStream("/images/external/JabRef-icon-48.png");
+                    InputStream fxmlStream = JabRef.class.getResourceAsStream("/gui/help/AboutDialogLayout.fxml");) {
+                DialogPane dialogContentPane = (DialogPane) loader.load(fxmlStream);
+                javafx.scene.image.Image img = new javafx.scene.image.Image(imageStream);


don't use abbreviation here. img-> image

boceckts · 2016-03-16T15:13:22Z

I created a new AboutDialog class which handles its initialization itself as previously. This way there are less changes and imports in the JabrefFrame class.
The improvements mentioned in the previous comments are also included.

Siedlerchr · 2016-03-17T09:51:51Z

Interestingly I found out that circle-ci is already using java8 u40:

Using Java 1.8.0_40 from /usr/lib/jvm/jdk1.8.0/jre
From the log of:
./gradlew -Pdev=true -Pinstall4jDir="install4j6" clean release --stacktrace || exit 0

boceckts · 2016-03-17T10:00:09Z

Thanks for pointing this out, I already wondered since I didn't touch the circle.yml yet the tests are passing on CircleCI.

simonharrer · 2016-03-17T10:01:47Z

src/main/java/net/sf/jabref/gui/help/AboutDialog.java

+            setDialogStyle(JabRefMain.class.getResource("/gui/help/AboutDialog.css").toExternalForm());
+        } catch (IOException e) {
+            logger.debug("AboutDialog could not be completely loaded!", e);
+        } catch (NullPointerException e) {


Do not catch NPEs.

koppor · 2016-03-20T19:18:58Z

Please ensure that this version of JabRef also runs under Linux with OpenJDK.

boceckts · 2016-03-20T19:44:18Z

As this states https://docs.travis-ci.com/user/trusty-ci-environment/ it should be possible to switch to the trusty beta build environment where we should be able to use the open jdk 1.8.0_60. I'm going to try this first before manually testing it.

koppor · 2016-04-25T07:07:12Z

We should sit together and think about a good design. I would like to have tabs instead of these strange pull down menus. Reason: responsiveness of the UI. If I click something, I want to read the things instantly. Proposal: Fix the minor issues here, then merge and then think about a good design of the dialog.

I liked the JabRef 3.2 About dialog more - maybe we can put each heading into a tab and render the first two paragraphs above that.

tobiasdiez · 2016-04-25T07:07:14Z

src/main/java/net/sf/jabref/gui/help/AboutDialogViewModel.java

+
+        websiteGithub.set("https://github.com/JabRef/jabref");
+
+        copyButtonText.set(Localization.lang("Copy_Version"));


Please change it back to %Copy Version in the fxml file. We will later provide a proper fix for this issue.

koppor · 2016-04-25T07:07:51Z

For reference: The current state of the dialog:

codecov-io · 2016-04-26T08:49:27Z

Current coverage is 27.32%

Merging #968 into javafx will decrease coverage by -0.00%

@@           javafx    #968   diff @@
=====================================
  Files         696     699     +3   
  Lines       46446   46557   +111   
  Methods         0       0          
  Branches     7703    7705     +2   
=====================================
+ Hits        12719   12721     +2   
- Misses      32628   32738   +110   
+ Partials     1099    1098     -1

2 files (not in diff) in .../net/sf/jabref/logic were modified. more
- Misses -1
- Hits +1
2 files (not in diff) in ...n/java/net/sf/jabref were modified. more
- Partials -1
- Hits +1

Powered by Codecov. Last updated by eeb7cf3

The old dialog and html layout file have been removed. The layout of the dialog panel is defined in the AboutDialog.fxml file located in the resources with its stylesheet. The AboutDialogViewModel class takes care of the text initialization of any components in the layout. It also implements any methodes called from any component of the dialog panel. The dialog is build and shown in the AboutDialogView class.

boceckts · 2016-04-26T09:00:24Z

I changed the code accordingly to your comments.
Note that at the current stage the dialog can not be shown as it throws an exception with the message Resource "Copy Version" not found.

tobiasdiez · 2016-04-26T10:25:27Z

I will now merge this PR in (in the JavaFX branch) so that you can work on further dialogs.

You are right, the keyboard shortcuts dialog looks relatively good. The "grab" button is probably superfluous and "Default" should specify if it resets just one shortcut or all. Moreover, I like the design in the Vivaldi browser:

See also the description https://help.vivaldi.com/article/keyboard-shortcuts/.
I especially like that the shortcuts are grouped.

koppor · 2016-09-07T16:58:05Z

Current state is still not that nice.

I know that removing code is hard, but could you please make the dialog appearing more than the old one and showing all information nice in one place? I think, we can show it on one page (maybe not the developers). We do not need collapsing for one liners.

boceckts · 2016-09-07T18:16:18Z

I will simplyfy it and remove the tab view.

boceckts · 2016-09-08T11:33:53Z

@JabRef/developers opinions to the following design?

Siedlerchr · 2016-09-08T11:44:22Z

Looks good! Just one minor thing, the URL for contributing seems to be not aligned at the same height as the label

tobiasdiez · 2016-09-08T12:30:04Z

Looks way better!
Only criticism:

The background color of the header is...well...ugly 😄
Display the URLs is unnecessary, better link text
Remove border around the authors field (if easily possible)
The license is wrong ( ? @koppor ? )
The sub-header "Developer" and "Authors" don't stand out.

I would slightly reorganize everything, but your version is also fine

(without the underlined text, that's a relict from the markup software)

Siedlerchr · 2016-09-08T13:55:46Z

@tobiasdiez and no Comic Sans MS style (as from the mockup) http://www.comicsanscriminal.com/ ;)

boceckts · 2016-09-09T10:48:53Z

So there are two new versions similar to what @tobiasdiez suggested.
(For some reason the authors contain weird characters for me)

It really looks a bit weird to me with so much space in the top but the information to display is rather small, maybe resize the dialog a bit smaller?

boceckts · 2016-09-09T14:00:56Z

I tried a smaller width for the dialog and personally this is my favorite, all the headings and information are left aligned and the icon has a small reflection which does not interfere with any text. Opinions are welcomed.

Siedlerchr · 2016-09-09T14:55:14Z

The small dialog looks good. ❤️

tobiasdiez · 2016-09-09T19:21:48Z

Yes I really love the smaller dialog. Good work! Where is the PR?? I want to merge it right-away 😄
(small suggestion: maybe move the "Developers" headline a bit down to increase the separation to the previous text)

Siedlerchr · 2016-09-09T22:37:11Z

@boceckts Could you please test with the gradle change I introduced in #1945 and see if authors now are displayed correctly`?. And please check the encoding of the Authors file (should be UTF-8 without BOM)

boceckts · 2016-09-10T13:55:09Z

@Siedlerchr the encoding is set to UTF-8 without BOM but unfortunately your changes have no effect for me.
@tobiasdiez There it is 😄 and I moved down the sub heading a little bit.

Siedlerchr · 2016-09-11T20:08:28Z

Regarding the encoding problems, I just fixed it with #1954. Please try again with the changes I made (gradle changes + version info)
And check: src\main\resources\build.properties if it is correctly encoded as utf8 without bom.

boceckts added the stupro-ready-for-internal-review label Mar 15, 2016

boceckts mentioned this pull request Mar 15, 2016

[WIP] Implemented about Dialog in Java FX #964

Closed

4 tasks

tobiasdiez reviewed Mar 15, 2016
View reviewed changes

boceckts force-pushed the AboutDialogFX branch from 29848ea to 5e0badd Compare March 15, 2016 15:42

boceckts force-pushed the AboutDialogFX branch from 5e0badd to 7c00a0e Compare March 15, 2016 16:05

koppor assigned boceckts Mar 15, 2016

tschechlovdev reviewed Mar 16, 2016
View reviewed changes

boceckts force-pushed the AboutDialogFX branch 2 times, most recently from 7c34de8 to ae7fbe7 Compare March 16, 2016 15:02

tschechlovdev added status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers and removed stupro-ready-for-internal-review labels Mar 16, 2016

tschechlovdev changed the title ~~[WIP] Implemented about dialog in Java FX~~ Implemented about dialog in Java FX Mar 16, 2016

simonharrer reviewed Mar 17, 2016
View reviewed changes

boceckts force-pushed the AboutDialogFX branch from ae7fbe7 to 1e5d6ba Compare March 17, 2016 10:41

boceckts force-pushed the AboutDialogFX branch from 1e5d6ba to 0d719fa Compare March 20, 2016 19:54

tobiasdiez reviewed Apr 25, 2016
View reviewed changes

Created super class for JavaFX dialogs on top of swing windows

fb1f4e7

boceckts force-pushed the AboutDialogFX branch from 0b5c099 to 729c7ca Compare April 26, 2016 08:49

boceckts force-pushed the AboutDialogFX branch from 729c7ca to 9907d3a Compare April 26, 2016 08:54

tobiasdiez merged commit f954e0b into JabRef:javafx Apr 26, 2016

koppor mentioned this pull request May 3, 2016

About dialog should enable copy and paste #871

Closed

boceckts deleted the AboutDialogFX branch May 6, 2016 10:25

tobiasdiez removed the status: devcall label May 10, 2016

tobiasdiez mentioned this pull request May 19, 2016

Support language keys with spaces for JavaFX #1426

Merged

3 tasks

boceckts mentioned this pull request May 25, 2016

Ported the KeyBindings dialog to JavaFX #1390

Merged

3 tasks

boceckts mentioned this pull request Sep 10, 2016

Redesigned about dialog in JavaFX #1947

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implemented about dialog in Java FX #968

Implemented about dialog in Java FX #968

boceckts commented Mar 15, 2016

simonharrer commented Mar 15, 2016

boceckts commented Mar 15, 2016

simonharrer commented Mar 15, 2016

Siedlerchr commented Mar 15, 2016

tobiasdiez Mar 15, 2016

koppor commented Mar 15, 2016

Siedlerchr commented Mar 15, 2016

boceckts commented Mar 15, 2016

tschechlovdev Mar 16, 2016

boceckts commented Mar 16, 2016

Siedlerchr commented Mar 17, 2016

boceckts commented Mar 17, 2016

simonharrer Mar 17, 2016

koppor commented Mar 20, 2016

boceckts commented Mar 20, 2016

koppor commented Apr 25, 2016

tobiasdiez Apr 25, 2016 •

edited

Loading

koppor commented Apr 25, 2016

codecov-io commented Apr 26, 2016 •

edited

Loading

boceckts commented Apr 26, 2016

tobiasdiez commented Apr 26, 2016

koppor commented Sep 7, 2016

boceckts commented Sep 7, 2016

boceckts commented Sep 8, 2016

Siedlerchr commented Sep 8, 2016

tobiasdiez commented Sep 8, 2016

Siedlerchr commented Sep 8, 2016

boceckts commented Sep 9, 2016

boceckts commented Sep 9, 2016

Siedlerchr commented Sep 9, 2016

tobiasdiez commented Sep 9, 2016 •

edited

Loading

Siedlerchr commented Sep 9, 2016

boceckts commented Sep 10, 2016

Siedlerchr commented Sep 11, 2016


		closeButton.setText(Localization.lang("Close"));

		copyButton.setText(Localization.lang("Copy_version_to_clipboard"));


		websiteGithub.set("https://github.com/JabRef/jabref");

		copyButtonText.set(Localization.lang("Copy_Version"));

Implemented about dialog in Java FX #968

Implemented about dialog in Java FX #968

Conversation

boceckts commented Mar 15, 2016

simonharrer commented Mar 15, 2016

boceckts commented Mar 15, 2016

simonharrer commented Mar 15, 2016

Siedlerchr commented Mar 15, 2016

tobiasdiez Mar 15, 2016

Choose a reason for hiding this comment

koppor commented Mar 15, 2016

Siedlerchr commented Mar 15, 2016

boceckts commented Mar 15, 2016

tschechlovdev Mar 16, 2016

Choose a reason for hiding this comment

boceckts commented Mar 16, 2016

Siedlerchr commented Mar 17, 2016

boceckts commented Mar 17, 2016

simonharrer Mar 17, 2016

Choose a reason for hiding this comment

koppor commented Mar 20, 2016

boceckts commented Mar 20, 2016

koppor commented Apr 25, 2016

tobiasdiez Apr 25, 2016 • edited Loading

Choose a reason for hiding this comment

koppor commented Apr 25, 2016

codecov-io commented Apr 26, 2016 • edited Loading

Current coverage is 27.32%

boceckts commented Apr 26, 2016

tobiasdiez commented Apr 26, 2016

koppor commented Sep 7, 2016

boceckts commented Sep 7, 2016

boceckts commented Sep 8, 2016

Siedlerchr commented Sep 8, 2016

tobiasdiez commented Sep 8, 2016

Siedlerchr commented Sep 8, 2016

boceckts commented Sep 9, 2016

boceckts commented Sep 9, 2016

Siedlerchr commented Sep 9, 2016

tobiasdiez commented Sep 9, 2016 • edited Loading

Siedlerchr commented Sep 9, 2016

boceckts commented Sep 10, 2016

Siedlerchr commented Sep 11, 2016

tobiasdiez Apr 25, 2016 •

edited

Loading

codecov-io commented Apr 26, 2016 •

edited

Loading

tobiasdiez commented Sep 9, 2016 •

edited

Loading