Redesigned about dialog in JavaFX #1947
Conversation
e8a8d16 to
f3ececf
Compare
f3ececf to
e73043e
Compare
| private final String LIBRARIES = "https://github.com/JabRef/jabref/blob/master/external-libraries.txt"; | ||
| private final String GITHUB = "https://github.com/JabRef/jabref"; | ||
| private final String CHANGELOG = "https://github.com/JabRef/jabref/blob/master/CHANGELOG.md"; | ||
| private final String LICENSE = "https://opensource.org/licenses/mit-license.php"; |
There was a problem hiding this comment.
|
LGTM, just change the link to the license and I think this can be merged. |
|
Please merge |
| Id: de.codecentric.centerdevice | ||
| Project: javafxsvg | ||
| URL: https://github.com/codecentric/javafxsvg | ||
| License: BSD 3-Clause |
|
@koppor Merged javafx, why do you want a new screenshot? The layout hasn't changed, only difference is that there is a small JabRef icon in the title bar of the dialog. |
| private final String DONATION = "http://www.jabref.org/#donations"; | ||
| private final String LIBRARIES = "https://github.com/JabRef/jabref/blob/master/external-libraries.txt"; | ||
| private final String GITHUB = "https://github.com/JabRef/jabref"; | ||
| private final String CHANGELOG = "https://github.com/JabRef/jabref/blob/master/CHANGELOG.md"; |
There was a problem hiding this comment.
Can we add a deep link here?
I would suggest https://github.com/koppor/keep-a-changelog/blob/master/CHANGELOG.md#unreleased for the development versions and add a release TODO to replace this by something like follow up at #1959https://github.com/JabRef/jabref/blob/master/CHANGELOG.md#36---2016-08-26
|
The about dialog is not centered on the screen. Does anyone else experience such an issue? |
|
I think it is centered on the main frame, not the screen. |
As discussed in #968 the about dialog is still not satisfying and therefore I redesigned it. The new design is a more flat like design with all important information in one place. The version still clickable and copies the version information to the clipboard and the logo is a hyperlink to www.jabref.org.
I also changed the copied version string to include JabRef, Java and OS version so it is the same as in the master branch.