-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discussion: Use crowdin for translation. #3470
Conversation
One reason for the failure are the missing underscores in the translation of german, e.g Prüfe Integrität |
We should get rid off the underscores anyway... Seem, they are an old
relict!
Am 29.11.2017 20:40 schrieb "Christoph" <notifications@github.com>:
… One reason for the failure are the missing underscores in the translation
of german, e.g Prüfe Integrität
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3470 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABTaftSXfC8RbfpQ2JT9PtmAmNvCOulAks5s7bMqgaJpZM4Qu5ty>
.
|
I'm fine with the change and the translation ui of crowdin looks nice. But in the end, the @JabRef/translators have to work with it. What is your opinion about this proposed change? |
To my great shame, I have not updated the Danish translation for years (but hope I might get time for it again). To the extent that I still have any say in this, I vote for Crowdin. I was never that happy about popeye anyway. I remember experiencing problems with the Danish letters æ, ø, å (I haven't checked, but I hope Crowdin is better at that).
|
My comments:
|
|
I close this PR, but we can continue discussing here. I will have to create some more PRs to get this thing running... |
In comparison to transifex, we have the automatic GitHub integration.
Pros and cons of crowdin
+
: Easy translation interface. Users can start joining at https://crwd.in/jabref.+
: Nice status overview - see https://crowdin.com/project/jabref - internal link: https://crowdin.com/project/jabref/settings#translations - fixes fixes https://github.com/JabRef/help.jabref.org/issues/171+
Translators do not require a login at GitHub and do not need to work with pull requests etc.+
Translations can still be made using our GitHub workflowjabref/src/main/java/org/jabref/logic/l10n/LocalizationKey.java
Line 25 in d45d7ca
-
At least one review of the translated string is required-
We cannot create our translation status page anymore (usingsyncLang.py
) as crowdin either (i) does not put a key at all or (ii) puts the English translation in the properties file. Checking for equality does not help asOK
is translated toOK
.-
It seems that generating the pull request has to be triggered manually.I would vote to go for crowdin to make it easy for interested people to work on the translation.
TODOs
id
vsin
. Result: The ISO-Code for Indonesia changed from "in" to "id". Java uses only the old one. See https://docs.oracle.com/javase/7/docs/api/java/util/Locale.html#Locale(java.lang.String), but Crowdin uses the new one. With a new mapping configuration on Crowdin, this is fixed.