Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion: Use crowdin for translation. #3470

Closed
wants to merge 43 commits into from
Closed

Discussion: Use crowdin for translation. #3470

wants to merge 43 commits into from

Conversation

koppor
Copy link
Member

@koppor koppor commented Nov 29, 2017

In comparison to transifex, we have the automatic GitHub integration.

Pros and cons of crowdin

I would vote to go for crowdin to make it easy for interested people to work on the translation.

TODOs

@koppor koppor added status: devcall status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers and removed status: devcall status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers labels Nov 29, 2017
@koppor koppor changed the title New Crowdin translations [WIP] New Crowdin translations Nov 29, 2017
@Siedlerchr
Copy link
Member

One reason for the failure are the missing underscores in the translation of german, e.g Prüfe Integrität

@koppor
Copy link
Member Author

koppor commented Nov 29, 2017 via email

@tobiasdiez
Copy link
Member

I'm fine with the change and the translation ui of crowdin looks nice. But in the end, the @JabRef/translators have to work with it. What is your opinion about this proposed change?

@ThomasA
Copy link
Member

ThomasA commented Nov 30, 2017

To my great shame, I have not updated the Danish translation for years (but hope I might get time for it again). To the extent that I still have any say in this, I vote for Crowdin. I was never that happy about popeye anyway. I remember experiencing problems with the Danish letters æ, ø, å (I haven't checked, but I hope Crowdin is better at that).
Two things I have not understood yet:

  • Does Crowdin still use/generate the .properties files?
  • Is it OK to just use spaces in strings instead of dealing with the horrible underscores?

@mlep
Copy link
Contributor

mlep commented Nov 30, 2017

My comments:

  • Nice and convenient interface
  • While translators will not require a login at GitHub, they seem to require one at Crowdin. What about anonymous contributions through Crowdin? Possible?
  • I hope that review can be skipped (or at least that translations do not need to be reviewed one-by-one).
  • Since the current Github workflow will continue to work, we can try out Crowdin and see if it helps to get better localizations of JabRef.

@koppor
Copy link
Member Author

koppor commented Nov 30, 2017

  • .properties: Yes, no change. Therefore, the GitHub workflow still works.
  • Yes, I will work on removing these underscores - I hate them 😇
  • Translators also need a login at GitHub. Otherwise, the pul requests don't work.
  • I did not see a way to skip the reviews, but this is a one-click thing. We can do it always before/after each devcall or when an email comes in. Think, this is not a show stopper

@koppor
Copy link
Member Author

koppor commented Nov 30, 2017

I close this PR, but we can continue discussing here. I will have to create some more PRs to get this thing running...

@koppor koppor closed this Nov 30, 2017
@koppor koppor changed the title [WIP] New Crowdin translations Discussion: Use crowdin for translation. Nov 30, 2017
@koppor koppor deleted the l10n_master branch December 11, 2017 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatic update of translation status
5 participants