Readd Drop Down content selectors #2301

Siedlerchr · 2016-11-20T17:37:53Z

First attempt at readding the code for
#2221
Refs #2068

Code does not compile yet, some adjustments need to be made regarding Metadata stuff etc

Change in CHANGELOG.md described
Tests created for changes
Screenshots added (for bigger UI changes)
Manually tested changed features in running JabRef
Check documentation status (Issue created for outdated help page at help.jabref.org?)
If you changed the localization: Did you run gradle localizationUpdate?

TODO: Metadata adjustment

Siedlerchr · 2016-11-25T14:17:35Z

@tobiasdiez There are some things with the Metadata to make it compile again. Could you please have a look? thanks!

tobiasdiez · 2016-11-25T20:49:41Z

How to handle the metadata is indeed a problem. I remember that I removed the content selectors mainly because they were the last not-so-easy-to-convert-to-the-new-metadata item. The next few days I will not find the time to assist you here, sorry.

…ntentSelector * 'master' of https://github.com/Siedlerchr/jabref: Rework DBLPFetcher to new structure (#2314) Consider dev tag in version comparison (#2312) Update diffutils from 1.3.0 to 2.1.1 Replace usages of Throwable with Exception (#2310) Add missing srcDir statement improve documentation of save order limitation - see #2305 Adapt CSL tests to CRLF and LF (#2306) Use SPDX license identifiers Add key format of #2275 as requirement to CONTRIBUTING.md Add fallback exception handler (#2287) Update citeproc dependency to 1.0.1 (#2303) Remove duplicate code getResolvedFieldOrAlias (#2296) Update testCompile dependencies (mockito-core, wiremock) Change execution order (#2302) Use https for files.jabref.org Use compileJava instead of getdeps to decrease build time even more Update install4j from 6.1.1 to 6.1.3 Fix local metadata synchronization

…to contentSelector * 'contentSelector' of https://github.com/JabRef/jabref: Comment out appending content selectors Repair content selector dialog Add new meta data structure for content selectors Fix some compile errors TODO: Metadata adjustment

Siedlerchr · 2016-11-28T14:56:30Z

Still some language related errors.

lenhard · 2016-11-28T15:11:04Z

The localization keys existed before the feature was removed. I wonder why the revert did not restore them in the language files?

Siedlerchr · 2016-11-28T15:51:09Z

I did a manual revert, because there were some more changes which would have led to conflicts otherwise.
Was somehow decided.

Fix NPE on JabRef startup

matthiasgeiger · 2016-11-28T17:56:41Z

As this was a rather old feature I suppose there were translations for most languages... Can you readd the translated values as well? Or should I go digging in the history? 😉

lenhard · 2016-11-30T16:10:27Z

So I re-implemented parsing and serialization of content selectors and added tests for it. It is probably not the most beautiful fashion, but I need to (want to) link to the old code and not have to re-write the GUI.

Speaking of the GUI: The content selectors seem to be working fine if the MetaData is in the bib file. The GUI in the EntryEditor is not actually beautiful, but I guess it has never been (does anybody feel like polishing the UI?). However, I do not see Options –> Manage content selectors. Maybe that has not been ported from #2068 yet? Maybe someone who is more familiar with the menu than me can have a look? :)

Finally, the test currently say:

net.sf.jabref.logic.help.HelpFileTest > referToValidPage FAILED

Although there seems to be a help page here: http://help.jabref.org/en/ContentSelector Someone certainly has a pointer for that?

Siedlerchr · 2016-11-30T16:19:43Z

Regarding the help file, there is an enum called HelpFiles or similar for the name of the help page I can take a look at the dialog thing in the menu Am 30.11.2016 5:10 nachm. schrieb "Jörg Lenhard" <notifications@github.com>:

So I re-implemented parsing and serialization of content selectors and

added tests for it. It is probably not the most beautiful fashion, but I need to (want to) link to the old code and not have to re-write the GUI.

Speaking of the GUI: The content selectors seem to be working fine if the

MetaData is in the bib file. The GUI in the EntryEditor is not actually beautiful, but I guess it has never been (does anybody feel like polishing the UI?). However, I do not see Options –> Manage content selectors. Maybe that has not been ported from #2068 yet? Maybe someone who is more familiar with the menu than me can have a look? :)

Finally, the test currently say: net.sf.jabref.logic.help.HelpFileTest > referToValidPage FAILED Although there seems to be a help page here:

http://help.jabref.org/en/ContentSelector Someone certainly has a pointer for that?

…

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

tobiasdiez · 2016-11-30T16:21:50Z

I pushed a commit which should take care of the menu item (hopefully, I directly edited it on github).

lenhard · 2016-11-30T16:28:26Z

@tobiasdiez Indeed, it does! Nice :) That means the feature is back!

Regarding the help files, there is CONTENT_SELECTOR("ContentSelector"), in net.sf.jabref.logic.help.HelpFile, so the test really should not fail, should it?

lenhard · 2016-12-01T09:55:38Z

@tobiasdiez I addressed most of your comments. I agree that "content selectors" is probably not the most appropriate name for the stuff this feature does, but it is the name under which it has existed for a long time and is known, at least by some people. I would say that consistency in naming tops appropriateness of the name.

Furthermore, I removed the entry editors update code, as you asked for. The updating of the content selectors did not even work with this code. I tried to replace it with something else and failed. So, for now you have to restart JabRef to get a change in the content selectors to work. Maybe someone from @JabRef/developers can provide a hint on how the refresh of the entry editor should work?

Finally, I will leave the problems in the localization for @Siedlerchr to fix :)

matthiasgeiger · 2016-12-01T09:57:47Z

Closing and reopening of the entry editor does not work? (Potentially with selecting another entry?)

lenhard · 2016-12-01T10:45:24Z

@matthiasgeiger Unfortunately not. The changed data makes it into the MetaData, but the GUI does not notice. It is only up-to-date when the MetaData is re-read from disk and the EntryEditor is re-built. Closing and reopening the bib file does the trick, or restarting JabRef

lenhard · 2016-12-02T12:33:21Z

So we would like to get this into v3.8, which hopefully can be released in december. What is missing:

correct the language files
have selector keywords updated without reloading of the bib file
Have the users play around with it to see if it really works

I was hoping that @Siedlerchr could do the first two points, and hopefully soon :-) @Siedlerchr what is your opinion on that?

Siedlerchr · 2016-12-02T12:37:48Z

Yeah, I will try to work on it. At least I tried to fix the language files, yesterday.
I will continue working on it the weekend

# Conflicts: # src/main/java/net/sf/jabref/gui/JabRefFrame.java

…g/~newren/eg/)

# Conflicts: # src/main/java/net/sf/jabref/gui/groups/GroupDialog.java # src/test/java/net/sf/jabref/logic/importer/fileformat/BibtexParserTest.java

tobiasdiez · 2016-12-12T10:27:06Z

src/main/java/net/sf/jabref/gui/contentselector/FieldContentSelector.java

            editor.append(FieldContentSelector.this.delimiter);
        }

-        editor.append(chosen);
+        // no duplicate -> add it
+        if (!currentText.contains(chosen)) {


I think it is better to reuse the KeywordList class here since keyword duplication is not as easy as it appears on first sight. For example, if the field contains "same test, something else" and I would like to add "test", then the simple "contains" solution marks this as duplicate although "same test" is not the same as "test" 😼.

Good point! I changed this to use the keyword list now.

# Conflicts: # src/main/java/net/sf/jabref/gui/JabRefFrame.java

Readd Drop Down content selectors

624dfa3

matthiasgeiger changed the title ~~Readd Drop Down content selectors~~ [WIP] Readd Drop Down content selectors Nov 21, 2016

Fix some compile errors

f8b451e

TODO: Metadata adjustment

lenhard and others added 8 commits November 28, 2016 13:19

Add new meta data structure for content selectors

667b07e

Repair content selector dialog

58b61e1

Comment out appending content selectors

3cff543

Merge branch 'master' into contentSelector

3058a44

Fix checkstyle error

6e12995

Fix codacy, use Interface instead of concrete type

f478661

Readd missing language keys

5f440bf

Fix NPE on JabRef startup

lenhard added 4 commits November 30, 2016 16:29

Rewrite parsing of content selectors in MetaData

9097438

Implement serialization of content selectors in MetaData

d49246b

Remove unused imports

83b47f6

Avoid duplicate serialization of _ in content selector MetaData

e5b5ef1

lenhard added this to the v3.8 milestone Nov 30, 2016

lenhard added 2 commits November 30, 2016 17:12

Fix content selector serialization test

264ab4b

Move MetaDataTest into the correct package

1e44cba

Add "Manage content selectors" menu entry

e5cc038

lenhard added 2 commits December 1, 2016 10:38

Fixes for review by @tobiasdiez

f4434cb

More review fixes

467c801

Revert lang file

9a57b42

lenhard and others added 7 commits December 5, 2016 13:50

Improve comment

9c99976

Also post change in case of selector deletion

0251904

Merge branch 'master' into contentSelector

1eeb858

# Conflicts: # src/main/java/net/sf/jabref/gui/JabRefFrame.java

Automatic revert of localization changes

22e07c6

Fix removal of content selectors

0a1150f

Add missing translation keys using [Easy Git](https://people.gnome.or…

ada1b8d

…g/~newren/eg/)

Add missing keys

95e0c7b

lenhard mentioned this pull request Dec 11, 2016

Customizable drop down menus for general fields are gone #2221

Closed

lenhard added 3 commits December 12, 2016 11:14

Avoid duplicates in selected words

da4d4bb

Merge branch 'master' into contentSelector

c428801

# Conflicts: # src/main/java/net/sf/jabref/gui/groups/GroupDialog.java # src/test/java/net/sf/jabref/logic/importer/fileformat/BibtexParserTest.java

Add changelog entry

172084e

tobiasdiez reviewed Dec 12, 2016

View reviewed changes

lenhard added 4 commits December 12, 2016 11:28

Try to fix issues in GroupSelector

9aaea76

Fix test that was weirdly broken by merge from master

73a1ea0

Detect duplicates based on Keyword list

2eaf074

Remove unused import

cf7ec17

lenhard added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Dec 13, 2016

lenhard added 2 commits December 16, 2016 13:38

Merge branch 'master' into contentSelector

1570464

# Conflicts: # src/main/java/net/sf/jabref/gui/JabRefFrame.java

Readd action removed by merge

4e38b11

Siedlerchr merged commit 108896f into master Dec 16, 2016

Siedlerchr deleted the contentSelector branch December 16, 2016 14:33

koppor changed the title ~~[WIP] Readd Drop Down content selectors~~ Readd Drop Down content selectors Dec 16, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Readd Drop Down content selectors #2301

Readd Drop Down content selectors #2301

Siedlerchr commented Nov 20, 2016

Siedlerchr commented Nov 25, 2016

tobiasdiez commented Nov 25, 2016

Siedlerchr commented Nov 28, 2016

lenhard commented Nov 28, 2016

Siedlerchr commented Nov 28, 2016

matthiasgeiger commented Nov 28, 2016

lenhard commented Nov 30, 2016

Siedlerchr commented Nov 30, 2016 via email

tobiasdiez commented Nov 30, 2016 •

edited

Loading

lenhard commented Nov 30, 2016

lenhard commented Dec 1, 2016

matthiasgeiger commented Dec 1, 2016

lenhard commented Dec 1, 2016

lenhard commented Dec 2, 2016

Siedlerchr commented Dec 2, 2016

tobiasdiez Dec 12, 2016 •

edited

Loading

lenhard Dec 12, 2016

Readd Drop Down content selectors #2301

Readd Drop Down content selectors #2301

Conversation

Siedlerchr commented Nov 20, 2016

Siedlerchr commented Nov 25, 2016

tobiasdiez commented Nov 25, 2016

Siedlerchr commented Nov 28, 2016

lenhard commented Nov 28, 2016

Siedlerchr commented Nov 28, 2016

matthiasgeiger commented Nov 28, 2016

lenhard commented Nov 30, 2016

Siedlerchr commented Nov 30, 2016 via email

tobiasdiez commented Nov 30, 2016 • edited Loading

lenhard commented Nov 30, 2016

lenhard commented Dec 1, 2016

matthiasgeiger commented Dec 1, 2016

lenhard commented Dec 1, 2016

lenhard commented Dec 2, 2016

Siedlerchr commented Dec 2, 2016

tobiasdiez Dec 12, 2016 • edited Loading

Choose a reason for hiding this comment

lenhard Dec 12, 2016

Choose a reason for hiding this comment

tobiasdiez commented Nov 30, 2016 •

edited

Loading

tobiasdiez Dec 12, 2016 •

edited

Loading