Remove content selectors #2068
Merged
Remove content selectors #2068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Auto-completion is basically broken but you can still remove this feature anyway 👍 |
|
Seems like a good idea. Never heard of them before |
|
I, too, cannot add an additional sensible use case, so removing is fine from my point of view. Note that, next to the failing localization tests, you also seem to have another failed test regarding to parsing content selectores |
6 tasks
zesaro
pushed a commit
to zesaro/jabref
that referenced
this pull request
Nov 22, 2016
* Remove content selectors * Fix parsing test * Remove localization * Fix roundtrip test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the "content selectors".
According to our help page, they are supposed "to store a selection of often-used words or phrases that you use often in your database". But exactly the same functionality is already there with the autocompletion. Thus I don't see any advantage of having the content selectors.
I did some background check and was not able to find a single bib file in the web which uses the content selectors. Moreover, the most discussions about them were from around 2004. The only feature request related to content selectors is the still open https://sourceforge.net/p/jabref/feature-requests/669/ which requests to store certain phrases that are often used in reviews.
I kind of see the use case there, but if this feature is really wished I would opt for a review template.
To be honest, I doubt that anybody even understood how to add phrases in the "Manage content selector" dialog, not to mention that probably nobody looked under "content selectors" for such a feature.
@JabRef/developers do you know of a good use case for this feature??
(will fix the localization stuff before merge)