Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple drupal #6

Merged
merged 1 commit into from
Jan 8, 2021
Merged

Allow multiple drupal #6

merged 1 commit into from
Jan 8, 2021

Conversation

whikloj
Copy link
Member

@whikloj whikloj commented Jan 7, 2021

No description provided.

@whikloj
Copy link
Member Author

whikloj commented Jan 7, 2021

@Islandora/8-x-committers this should have no effect on current builds but will enable multiple Drupal version testing ala Islandora/islandora#821

Copy link
Member

@elizoller elizoller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like Islandora/islandora#821 tests went green for 8.9 and 9.1 so we should be good to go, right?

@elizoller elizoller mentioned this pull request Jan 8, 2021
@whikloj
Copy link
Member Author

whikloj commented Jan 8, 2021

No, Islandora/islandora#821 passed because islandora_ci can only run 8.9.11. It just ran it 6 times instead of 3.

@whikloj
Copy link
Member Author

whikloj commented Jan 8, 2021

Before I opened the draft pr I did run a test. I can show you how to run your own tomorrow if you'd like.

@elizoller
Copy link
Member

Ah ok, talk to you tomorrow then 👍

@elizoller
Copy link
Member

With @whikloj 's help, i was able to test the islandora_ci change on the islandora module here: https://travis-ci.com/github/asulibraries/islandora/builds/212494945
which created 12 builds
php 7.3 / drupal 8 / kernel
php 7.3 / drupal 8 / functional
php 7.3 / drupal 8 / functional-javascript
php 7.3 / drupal 9 / kernel
php 7.3 / drupal 9 / functional
php 7.3 / drupal 9 / functional-javascript
php 7.4 / drupal 8 / kernel
php 7.4 / drupal 8 / functional
php 7.4 / drupal 8 / functional-javascript
php 7.4 / drupal 9 / kernel
php 7.4 / drupal 9 / functional
php 7.4 / drupal 9 / functional-javascript

verified that the correct PHP version and drupal version was installed so i think this is good to go

@elizoller elizoller merged commit 831d8f2 into Islandora:main Jan 8, 2021
@whikloj whikloj deleted the multi-drupal branch January 8, 2021 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants