Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi Drupal #821

Closed
wants to merge 1 commit into from
Closed

Multi Drupal #821

wants to merge 1 commit into from

Conversation

whikloj
Copy link
Member

@whikloj whikloj commented Jan 7, 2021

JIRA Ticket: n/a

What does this Pull Request do?

Updates the travis setup to test both Drupal 8.9.11 and 9.1.1 requires Islandora/islandora_ci#6

What's new?

Defines new environment variable DRUPAL_VERSION in the build matrix.

How should this be tested?

Once Islandora/islandora_ci#6 is merged, I'll make this live and it should both pass and test both Drupal 8 and 9.

Interested parties

@Islandora/8-x-committers

@whikloj whikloj marked this pull request as ready for review January 8, 2021 17:16
Copy link
Member

@elizoller elizoller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since I copy/pasta-ed this .travis.yml change into a local branch in order to test the islandora_ci PR Islandora/islandora_ci#6, I think this already gets the green light from me.

@elizoller
Copy link
Member

my only question on this is - does this mean we have to update this every time drupal releases a point release for d8 and d9?

@whikloj
Copy link
Member Author

whikloj commented Jan 12, 2021

Ummm yes, I guess we could switch to using the 8.9.x and 9.1.x branches. There are some slight differences in the composer.json files which may or may not affect anything. Also this or #823 is redundant.

@whikloj
Copy link
Member Author

whikloj commented Jan 13, 2021

Closing this in favour of #823

@whikloj whikloj closed this Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants