Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the topics and services listed in the README #3215

Open
wants to merge 2 commits into
base: ros2-development
Choose a base branch
from

Conversation

louislelay
Copy link

I updated the topics and services listed in the README file. As when we run ros2 topic list and ros2 service list after launching the sames commands, the previous output displayed were out of date.

This came from conversation we had in the following issue (3208) : #3208

…ist and ros2 service list, as the previous ones were out of date.
@sysrsbuild
Copy link

Can one of the admins verify this patch?

@louislelay
Copy link
Author

Hi @sysrsbuild @SamerKhshiboun & @Nir-Az,
I noticed that this PR has been reviewed and updated with main, but it hasn't been merged yet. Is there anything else needed from my side to help move it forward? Let me know if there's anything I can do to assist. Thanks!

@Nir-Az Nir-Az requested a review from remibettan February 12, 2025 07:59
@Nir-Az
Copy link
Collaborator

Nir-Az commented Feb 12, 2025

Hi @sysrsbuild @SamerKhshiboun & @Nir-Az, I noticed that this PR has been reviewed and updated with main, but it hasn't been merged yet. Is there anything else needed from my side to help move it forward? Let me know if there's anything I can do to assist. Thanks!

Hi @louislelay ,

Sorry for that probably this fall between our tasks.
Let me add @remibettan to confirm the changes are still updated and we can later continue with merging it.
Thanks!

@louislelay
Copy link
Author

No problem, @Nir-Az! Just following up. Thanks for the quick answer!

Copy link
Collaborator

@remibettan remibettan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @louislelay - thanks for your contribution!
Working on the ros2-development branch, I had the following results:

ros2 topic list
/parameter_events
/robot1/D455_1/color/camera_info
/robot1/D455_1/color/image_raw
/robot1/D455_1/color/metadata
/robot1/D455_1/depth/camera_info
/robot1/D455_1/depth/image_rect_raw
/robot1/D455_1/depth/metadata
/robot1/D455_1/extrinsics/depth_to_color
/rosout
/tf_static

ros2 service list
/robot1/D455_1/calib_config_read
/robot1/D455_1/calib_config_write
/robot1/D455_1/describe_parameters
/robot1/D455_1/device_info
/robot1/D455_1/get_parameter_types
/robot1/D455_1/get_parameters
/robot1/D455_1/get_type_description
/robot1/D455_1/hw_reset
/robot1/D455_1/list_parameters
/robot1/D455_1/set_parameters
/robot1/D455_1/set_parameters_atomically

These results are slightly different from yours.
Please tell me if you can check and eventually fix it in your Pull Request.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants