Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make folder for driver consistent with package name ("realsense_camera") #33

Closed
skohlbr opened this issue Apr 24, 2016 · 4 comments
Closed

Comments

@skohlbr
Copy link

skohlbr commented Apr 24, 2016

It is a (nearly) ubiquitously used convention within the ROS community to name a folder where a package resides the same as the package name in the package.xml file. Especially users new to ROS might be confused by the driver being placed in the "camera" folder instead of "realsense_camera" (which is the actual package name according to the package.xml.

@mkhansenbot
Copy link

Thanks for the input. We'll discuss internally and decide whether to proceed with this change.

@mdhorn
Copy link

mdhorn commented May 25, 2016

This change will be in the the next release.

Next release is pending on a new release of https://github.com/IntelRealSense/librealsense/ due out soon.

@mdhorn mdhorn mentioned this issue Jun 4, 2016
@mdhorn
Copy link

mdhorn commented Jun 6, 2016

Librealsense v0.9.2 was released.
ROS Realsense package will be releasing shortly with this fix; should be version 1.1.0.

@mdhorn
Copy link

mdhorn commented Jun 7, 2016

Fixed in Release 1.1.0

@mdhorn mdhorn closed this as completed Jun 7, 2016
mdhorn pushed a commit to mdhorn/realsense that referenced this issue Jul 13, 2016
doronhi pushed a commit that referenced this issue Nov 10, 2020
Enable infrared RGB from launch file. Readme changes indicating new feature
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants