Lodestar should pass fee market test #61
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tory (#48) * Add common beacon chain config file * Move PRESET_BASE to top of config file * bump service start timeout from 1 to 2 min * Revert timeout change from 2 minutes to 60 sec Co-authored-by: Roberto Bayardo <bayardo@alum.mit.edu>
* Add historical sync test (#44) Asserts that the beacon node follower can sync blobs during initial-sync. This patch also refactors the test harness to accommodate dynamic nodes. * update subrepos to latest Co-authored-by: Inphi <mlaw2501@gmail.com>
… Lodestar pre-4844 test in CI
Lodestar devnet 3
Parallelize Prysm and Lodestar test suites
Fix clean
52361bc to
ca0dffe
Compare
dgcoffman
commented
Nov 17, 2022
| @@ -1,3 +1,4 @@ | |||
| .git | |||
| .github | |||
| node_modules | |||
| **/node_modules | |||
There was a problem hiding this comment.
this appears to be necessary to avoid copying the compiled kzg.node, which won't work if you have an OSX host, and the docker is Linux.
dgcoffman
commented
Nov 17, 2022
| BlobKzgs []string `json:"blob_kzgs"` | ||
| // Does Prysm call this "blob_kzgs"? That's wrong. | ||
| // BlobKzgs []string `json:"blob_kzgs"` | ||
| BlobKzgs []string `json:"blob_kzg_commitments"` |
There was a problem hiding this comment.
Prysm should be updated?
There was a problem hiding this comment.
yup good catch, let me fix.
|
#66 will take this forward |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates Lodestar to head of my branch dgcoffman/lodestar#1
Fixes one issue where the Go test code expects a JSON field to be named something different than what it is in Lodestar.
Tests won't pass here until Go can talk to Lodestar's p2p method
blobs_sidecars_by_range-- which it currently does not.