Make all beacon chain config values explicit and move to common directory #48
Conversation
|
Oh hm this is breaking the continuous build tests; looks like the prysm beacon nodes might not be coming up? Does the failing test (go run ./tests/pre-4844) pass for you locally? |
Hi @roberto-bayardo thanks for the looking into this! I'll try running the tests locally. Not sure if |
|
EDIT: I just reverted the change and the test still passes 😅 let me take a look again on the CI logs.. |
|
@jimmygchen make sure you run "make devnet-clean" or similar to force a rebuild between changes! I have made that mistake many a time.... the current scripts aren't smart enough to rebuild what's needed when you make changes to the subrepos. |
|
Hmm tests are working for me locally when I include your PR. Wonder if the CI config needs to be updated somehow. |
|
I think our timeout is just too short... maybe they started running the CIs on slower machines! I will try doubling it. |
|
Ahah, they seem to be running the CI on older processors without the instructions expected
@jimmygchen I will fix this later.. feel free to merge (you can back out my timeout update & the PRESET_BASE change if you liike) |
|
ahh nice catch. Thanks for looking into this! I'll revert the timeout changes and keep the |
…tory (#48) * Add common beacon chain config file * Move PRESET_BASE to top of config file * bump service start timeout from 1 to 2 min * Revert timeout change from 2 minutes to 60 sec Co-authored-by: Roberto Bayardo <bayardo@alum.mit.edu>
…ongoing development (#60) * create devnet v3 branch including submodules + new submodule for erigon client * Add Lodestar * Supply chain config * Cache all docker work before yarn build * Build packages individually to allow them to cache * We must also build the CLI * Fix clean * Update to head of Lodestar * Fun through Capella * Latest Lodestar * latest prsym * Remove nonfunctional setting * Bump Lodestar * update geth to latest merge w/ master (#46) * Make all beacon chain config values explicit and move to common directory (#48) * Add common beacon chain config file * Move PRESET_BASE to top of config file * bump service start timeout from 1 to 2 min * Revert timeout change from 2 minutes to 60 sec Co-authored-by: Roberto Bayardo <bayardo@alum.mit.edu> * add BLST_PORTABLE to CGO_CFLAGS to fix SIGILL issue with blst (#49) * Update lodestar submodule. Copy trusted setup * Update devnet v3 with latest subrepos and new test from master (#51) * Add historical sync test (#44) Asserts that the beacon node follower can sync blobs during initial-sync. This patch also refactors the test harness to accommodate dynamic nodes. * update subrepos to latest Co-authored-by: Inphi <mlaw2501@gmail.com> * Update test harness to start either prysm or lodestar * Fix the Prysm communication * Fix the Lodestar wiring * Fix up validator <-> beacon node communication * Start switching tests to real beacon API * fee-market tests pass against Prysm without gRPC * Fix initial-sync test * Switch prysm to my branch which has GetBlockJSON * Configure Prysm to upgrade later (as though it had Capella). Also run Lodestar pre-4844 test in CI * Fix make lodestar-up * Remove Prysm-specific chain config. We used a shared config now. * Point Prysm back at the devnet-v3 branch * Update geth to latest from devnet-v3 * Put erigon back * Remove preset base, let it take the default * Attempt to parallelize CI * idunno lol * Try two jobs * Comment failing Lodestar CI test * Fix clean * Use basename pwd instead * Go back to using --project-name, but correctly supply it to docker compose down also * upgrade subrepos to latest (#56) * update geth & prysm subrepos to latest, pointing at eip-4844 instead of devnet-v3 (#57) * update subrepos to latest, move back to using eip-4844 branch for development * add 30 min timeout to some tests that sometimes hang * fix CI, Makefile, and update Prysm & geth subrepos Note: the new prysm & geth subrepos use a different kzg trusted setup matching, which now matches the latest consensus spec Co-authored-by: dancoffman <coffman@coinbase.com> Co-authored-by: Jimmy Chen <jchen.tc@gmail.com> Co-authored-by: Inphi <mlaw2501@gmail.com> Co-authored-by: Daniel Coffman <dgcoffman@gmail.com>
Prysm populate mainnet config values by default if any value is not supplied.
This behaviour does not exist on other clients (Teku, Lighthouse afaik). Making these explicit in the common beacon config will allow all other clients to easily reuse them.