Skip index signatures in no-shadowed-variable rule (fixes palantir#1258)

IllusionMH · Aug 14, 2016 · 759be68 · 759be68
1 parent bd0c45f
commit 759be68
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/rules/noShadowedVariableRule.ts b/src/rules/noShadowedVariableRule.ts
@@ -85,8 +85,9 @@ class NoShadowedVariableWalker extends Lint.BlockScopeAwareRuleWalker<ScopeInfo,
 
     public visitParameterDeclaration(node: ts.ParameterDeclaration) {
         const isSingleParameter = node.name.kind === ts.SyntaxKind.Identifier;
+        const isIndexSignature = node.parent.kind === ts.SyntaxKind.IndexSignature;
 
-        if (isSingleParameter) {
+        if (isSingleParameter && !isIndexSignature) {
             this.handleSingleParameterIdentifier(<ts.Identifier> node.name);
         }
 

diff --git a/test/rules/no-shadowed-variable/test.ts.lint b/test/rules/no-shadowed-variable/test.ts.lint
@@ -161,3 +161,8 @@ function testParameterDestructuring(
 function testSimpleBlockVar() {
     const simpleBlockVar = 4
 }
+
+interface IFoo {
+    [i: string]: any;
+    [i: number]: any;
+}