Revert "Require semicolon for type alias" (palantir#1477)

IllusionMH · Aug 12, 2016 · bd0c45f · bd0c45f
1 parent 6f3d73b
commit bd0c45f
Show file tree

Hide file tree

Showing 6 changed files with 0 additions and 28 deletions.
diff --git a/src/language/walker/syntaxWalker.ts b/src/language/walker/syntaxWalker.ts
@@ -286,10 +286,6 @@ export class SyntaxWalker {
         this.walkChildren(node);
     }
 
-    protected visitTypeAliasDeclaration(node: ts.TypeAliasDeclaration) {
-        this.walkChildren(node);
-    }
-
     protected visitTypeAssertionExpression(node: ts.TypeAssertion) {
         this.walkChildren(node);
     }
@@ -588,10 +584,6 @@ export class SyntaxWalker {
                 this.visitTryStatement(<ts.TryStatement> node);
                 break;
 
-            case ts.SyntaxKind.TypeAliasDeclaration:
-                this.visitTypeAliasDeclaration(<ts.TypeAliasDeclaration> node);
-                break;
-
             case ts.SyntaxKind.TypeAssertionExpression:
                 this.visitTypeAssertionExpression(<ts.TypeAssertion> node);
                 break;

diff --git a/src/rules/semicolonRule.ts b/src/rules/semicolonRule.ts
@@ -140,11 +140,6 @@ class SemicolonWalker extends Lint.RuleWalker {
         super.visitExportAssignment(node);
     }
 
-    public visitTypeAliasDeclaration(node: ts.TypeAliasDeclaration) {
-        this.checkSemicolonAt(node);
-        super.visitTypeAliasDeclaration(node);
-    }
-
     private checkSemicolonAt(node: ts.Node) {
         const sourceFile = this.getSourceFile();
         const children = node.getChildren(sourceFile);

diff --git a/test/rules/semicolon/always/test.ts.lint b/test/rules/semicolon/always/test.ts.lint
@@ -84,6 +84,3 @@ export = Date;
 export = Date
              ~nil [Missing semicolon]
 
-type t = number;
-type t = number
-               ~nil [Missing semicolon]
diff --git a/test/rules/semicolon/enabled/test.ts.lint b/test/rules/semicolon/enabled/test.ts.lint
@@ -83,7 +83,3 @@ export default LoginPage
 export = Date;
 export = Date
              ~nil [Missing semicolon]
-
-type t = number;
-type t = number
-               ~nil [Missing semicolon]
diff --git a/test/rules/semicolon/ignore-interfaces/test.ts.lint b/test/rules/semicolon/ignore-interfaces/test.ts.lint
@@ -83,7 +83,3 @@ export default LoginPage
 export = Date;
 export = Date
              ~nil [Missing semicolon]
-
-type t = number;
-type t = number
-               ~nil [Missing semicolon]
diff --git a/test/rules/semicolon/never/test.ts.lint b/test/rules/semicolon/never/test.ts.lint
@@ -116,7 +116,3 @@ export default LoginPage
 export = Date;
              ~ [Unnecessary semicolon]
 export = Date
-
-type t = number;
-               ~ [Unnecessary semicolon]
-type t = number