Iqss/6725 analytics bug

[qqmyers]

What this PR does / why we need it: Fixes a bug in the analytics-code.html example file in the docs, which breaks button-level tracking for Google analytics.

Which issue(s) this PR closes:

Closes #6725

Special notes for your reviewer:

Suggestions on how to test this:
The issue shows a javascript console error that should go away when the fix is applied.

Does this PR introduce a user interface change?:

Is there a release notes update needed for this change?:
Up to you - I created one. To fix the bug, installations have to reinstall the analytics-code.html file or modify their existing one. It does look to me like this has been broken since ~v.417 - hard to tell if it was a bug/typo in the code or if a UI change broke things at some point. (Pretty sure it worked to start but I can't say when the UI change might have happened.) That said, it only affects installs that have deployed a custom analytics file though.

Additional documentation:

[coveralls]

Coverage remained the same at 19.444% when pulling 3597435 on QualitativeDataRepository:IQSS/6725-analytics-bug into c4dd4a5 on IQSS:develop.

[mheppler]

@qqmyers looking at the latest and greatest version of this example code in the develop and master branches, I do not see a typo/missing character.

https://github.com/IQSS/dataverse/blob/develop/doc/sphinx-guides/source/_static/installation/files/var/www/dataverse/branding/analytics-code.html

Is it possible this may only be an issue on your fork?

[qqmyers]

The issue is in line 120 - the '>' character there only finds direct children which is not the case. It should be removed.

[mheppler]

D'oh. Apologies. I was seeing your changes backwards, while looking at our analytics code and wonder how we already had the direct child selector... 🤦‍♂.

But, while I was in there, I did do a little more digging into the dataset pg source code for the files table, and looking at those td.col-file-metadata table columns. I think that rather than relying on the selector to through that entire block of code, we could keep the original direct child selector and use a different container.

<div class="file-metadata-block">
    <a href="/file.xhtml?persistentId=doi:10.7910/DVN/XXXXXX/XXXXXX&amp;version=2.0">
        Sample.txt
    </a>
...

I haven't tested it, but I believe we could use div.file-metadata-block > a to achieve the same selection of the file id/DOI in the dataset page.

[qqmyers]

@mheppler - that looks fine too. If you change it, the release notes should change to match.

[mheppler]

@qqmyers PR QualitativeDataRepository#39 submitted. Release notes did not specify the change, so it did not need revising.

[mheppler]

👍