Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

analytics tracking broken for download button #6725

Closed
qqmyers opened this issue Mar 4, 2020 · 0 comments · Fixed by #6726
Closed

analytics tracking broken for download button #6725

qqmyers opened this issue Mar 4, 2020 · 0 comments · Fixed by #6726

Comments

@qqmyers
Copy link
Member

qqmyers commented Mar 4, 2020

Hitting download shows the following in the browser javascript console:
Uncaught TypeError: Cannot read property 'indexOf' of undefined
at stripId (dataset.xhtml?persistentId=doi:10.18738/T8/F3QE0H:135)
at getFileId (dataset.xhtml?persistentId=doi:10.18738/T8/F3QE0H:128)
at HTMLAnchorElement. (dataset.xhtml?persistentId=doi:10.18738/T8/F3QE0H:18)
at HTMLDocument.dispatch (jquery.js.xhtml?ln=primefaces&v=6.2:2)
at HTMLDocument.v.handle (jquery.js.xhtml?ln=primefaces&v=6.2:2)

I think this code used to work, but it could be a typo in the example file in the documentation as well. In either case, changing the selector allows the right file identifier to be found so that the download can be tracked in google analytics. PR to follow.
@qqmyers qqmyers mentioned this issue Mar 4, 2020
Merged
mheppler added a commit that referenced this issue Mar 6, 2020
@mheppler
Changed selector in analytics exmaple to be more precise [ref #6725]
1e5951f
qqmyers added a commit to QualitativeDataRepository/dataverse that referenced this issue Mar 6, 2020
@qqmyers
Merge pull request #39 from IQSS/6725-analytics-selector-redux
3597435 
Changed selector in analytics exmaple to be more precise [ref IQSS#6725]
qqmyers added a commit to GlobalDataverseCommunityConsortium/dataverse that referenced this issue Dec 3, 2021
@qqmyers
Revert "Changed selector in analytics exmaple to be more precise [ref I…
ce863d2 
…QSS#6725]"

This reverts commit 1e5951f.
@qqmyers qqmyers mentioned this issue Dec 3, 2021
Merged
poikilotherm pushed a commit to poikilotherm/dataverse that referenced this issue Dec 15, 2021
@qqmyers @poikilotherm
Revert "Changed selector in analytics exmaple to be more precise [ref I…
b8f1d28 
…QSS#6725]"

This reverts commit 1e5951f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Iqss/6725 analytics bug QualitativeDataRepository/dataverse
1 participant
@qqmyers