Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent JSF validation error on Payara 5 #4172 #5933

Merged
merged 1 commit into from
Jun 12, 2019

Conversation

pdurbin
Copy link
Member

@pdurbin pdurbin commented Jun 11, 2019

The issue for supporting Payara 5 at #4172 and the issue for not being locked to Glassfish 4.1 at #2628 are both related but this is a "small chunk" fix that I don't believe causes any problems on Glassfish 4.1. Thank you to @smillidge for the suggestion at #4172 (comment)

Here is the error that I am trying to prevent on Payara 5.192 when visiting the home page of Dataverse:

58837007-51c21b00-8628-11e9-9040-c25cb33dc276

I see #4172 as representing full support for Payara 5 in the sense of an updated Dataverse Installation Guide, etc. so this pull request is not intended as a fix for that issue. Rather, the idea is to do no harm to existing Dataverse installations on Glassfish 4.1 but help move the needle on Payara 5 support.

Without a fix like this (or similar), JSF throws a validation error when
you visit the home page.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 19.697% when pulling 7b53c62 on payara5-validation-error into 86bb329 on develop.

@pdurbin
Copy link
Member Author

pdurbin commented Jun 12, 2019

@scolapasta as I mentioned at standup, @poikilotherm did a lot of great research into the wee hours last night. The entire conversation is in IRC:

This is a lot of information to absorb but the highlights are:

Screen Shot 2019-06-12 at 11 32 55 AM

@pdurbin
Copy link
Member Author

pdurbin commented Jun 13, 2019

Unfortunately we had to revert this pull request with pull request #5944 because we were unable to create dataverses anymore. 😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants