use "root" as default alias, handle page=0 #5907 #5913
Conversation
| @@ -307,6 +307,10 @@ public void search(boolean onlyDataRelatedToMe) { | |||
| String allTypesFilterQuery = SearchFields.TYPE + ":(dataverses OR datasets OR files)"; | |||
| filterQueriesFinalAllTypes.add(allTypesFilterQuery); | |||
|
|
|||
| if (page == 0) { | |||
There was a problem hiding this comment.
@pdurbin the log message makes me think we don't know why this is here? Can we find out if this is needed and why? I'd rather be sure of why we're adding in logic than just logging a ¯_(ツ)_/¯
There was a problem hiding this comment.
@scolapasta yes, the message could be better. It is needed (or something like it) to avoid a 500 error like this:
There was a problem hiding this comment.
@poikilotherm I just tested your fix in bd25409 but by cherry-picking it into e4946bc but I'm still getting the same 500 error and java.lang.IllegalArgumentException: paginationStart must be 0 or greater at edu.harvard.iq.dataverse.search.SearchServiceBean.search(SearchServiceBean.java:148) in the logs. Here are some screenshots:
|
@scolapasta 00fb3d0 has two fixes in one commit which was probably misguided of me. I just created pull request #5933 as a smaller chunk. |
I'm closing this pull request in favor of pull request #5933. |
Related to #5907, an alternative to pull request #5908.
This pull request feels like progress in getting Dataverse to work properly on Payara 5 in the sense that there is no validation error when you visit the homepage and after logging in as dataverseAdmin, one does not see an Internal Server Error. However, the "Create Dataverse" button doesn't work. The page flashes and you land on http://ec2-34-207-192-222.compute-1.amazonaws.com:8080/dataverse.xhtml?ownerId=1 (for example) but you are not redirected to the "create dataverse" page.