Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test_frontal_area_index, use math.inf and math.nan #77

Merged
merged 15 commits into from
Oct 17, 2023

Conversation

erexer
Copy link
Collaborator

@erexer erexer commented Oct 17, 2023

closes #44

@erexer erexer requested a review from levisweetbreu October 17, 2023 00:37
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #77 (ee74c8a) into feature/nodes (821d4e6) will increase coverage by 1.59%.
Report is 11 commits behind head on feature/nodes.
The diff coverage is n/a.

❗ Current head ee74c8a differs from pull request most recent head 6523e14. Consider uploading reports for the commit 6523e14 to get more accurate results

@@                Coverage Diff                @@
##           feature/nodes      #77      +/-   ##
=================================================
+ Coverage          66.06%   67.66%   +1.59%     
=================================================
  Files                  4        4              
  Lines                501      501              
=================================================
+ Hits                 331      339       +8     
+ Misses               170      162       -8     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@levisweetbreu levisweetbreu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good, but frontal_area_index() has changed #79

@erexer
Copy link
Collaborator Author

erexer commented Oct 17, 2023

closes #79

@erexer erexer merged commit 901387d into feature/nodes Oct 17, 2023
@erexer erexer deleted the feature/test_frontal_area_index branch October 17, 2023 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants