add test_height_to_width_ratio() #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## feature/nodes #75 +/- ##
=================================================
+ Coverage 66.06% 66.26% +0.19%
=================================================
Files 4 4
Lines 501 501
=================================================
+ Hits 331 332 +1
+ Misses 170 169 -1 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
levisweetbreu
approved these changes
Oct 17, 2023
erexer
added a commit
that referenced
this pull request
Oct 17, 2023
* added lot_area() * added frontal_area() * reformatted frontal_area_index() * added frontal_area and lot_area() to macdonald_roughness_length() * add test_frontal_area_index, use math.inf and math.nan * add test_height_to_width_ratio() (#75) * add test_building_surface_area_to_plan_area_ratio (#78) * add new functions * redo column naming in frontal_area() * add test_sky_view_factor() (#72) * add test_complete_aspect_ratio (#76) * add test_frontal_area_index, use math.inf and math.nan * update test_frontal_area_index() --------- Co-authored-by: levisweet <lsweet@vols.utk.edu> Co-authored-by: Levi Sweet-Breu <99049421+levisweetbreu@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #42