fixrule(text_contrast_sufficient): Support CJK large scale text in color contrast calculation
#1888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tombrunet
previously approved these changes
Apr 5, 2024
|
Please review the conflicts @shunguoy |
ErickRenteria
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following formats should be used for the release notes and PRs.
Rule/Engine updates:
fixrule(
text_contrast_sufficient): Support CJK large scale text in color contrast calculationThis PR is related to the following issue(s):
fixes #1735
Additional information can be found here:
Testing reference:
test cases: test/v2/checker/accessibility/rules/text_contrast_sufficient_ruleunit/cjk_fail.html
After the fixes, several color contrast violations are reported on the buttons with the message: Text contrast of 3.86 with its background is less than the WCAG AA minimum requirements for text of size 12px and weight of 400.
I have conducted the following for this PR: