Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: Confirm that contrast rule properly handles non-latin fonts #1735

Closed
tombrunet opened this issue Nov 3, 2023 · 3 comments · Fixed by #1888
Closed

[BUG]: Confirm that contrast rule properly handles non-latin fonts #1735

tombrunet opened this issue Nov 3, 2023 · 3 comments · Fixed by #1888
Assignees
@shunguoy
Labels
ACT Issues/Rules related to ACT engine Issues in the accessibility-checker-engine component priority-2 (med) Ready for QA Standards T54 Triage release 5.4

Comments

@tombrunet
Copy link
Member

Project

accessibility-checker-engine

Browser

Chrome

Operating system

MacOS

Description

See https://github.com/act-rules/act-rules.github.io/pull/2121/files

Steps to reproduce

See above
@tombrunet
Copy link
Member Author

tombrunet commented Nov 6, 2023 •
edited by ErickRenteria
Loading

See https://www.w3.org/WAI/WCAG21/Understanding/contrast-minimum.html (search for "CJK" in notes)

Note
The 18 and 14 point sizes for roman texts are taken from the minimum size for large print (14pt) and the larger standard font size (18pt). For other fonts such as CJK languages, the "equivalent" sizes would be the minimum large print size used for those languages and the next larger standard large print size.

@shunguoy shunguoy added ACT Issues/Rules related to ACT T54 Triage release 5.4 engine Issues in the accessibility-checker-engine component priority-2 (med) labels Nov 6, 2023
shunguoy added a commit that referenced this issue Mar 29, 2024
@shunguoy
update the contrast rule to include CJK #1735
91e7479
shunguoy added a commit that referenced this issue Apr 2, 2024
@shunguoy
update color contrast rule and the test cases #1735
1a43415
@shunguoy shunguoy mentioned this issue Apr 3, 2024
Merged
5 tasks
shunguoy added a commit that referenced this issue Apr 3, 2024
@shunguoy
update the baselines #1735
d917a7a
shunguoy added a commit that referenced this issue Apr 3, 2024
@shunguoy
debug the baseline errors #1735
b06f6b1
shunguoy added a commit that referenced this issue Apr 3, 2024
@shunguoy
update the test results #1735
4bd6c30
@shunguoy
Copy link
Contributor

shunguoy commented Apr 4, 2024

requested @tombrunet for review.

@ErickRenteria
Copy link
Contributor

Validated
Screenshot 2024-04-08 at 8 34 46 PM

shunguoy added a commit that referenced this issue Apr 11, 2024
@shunguoy
update the baseline for merge conflict #1735
9c789ba
shunguoy added a commit that referenced this issue Apr 11, 2024
@shunguoy
debug the baseline issue #1735
7921f1b
shunguoy added a commit that referenced this issue Apr 11, 2024
@shunguoy
debug baseline issues #1735
895dbbd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shunguoy shunguoy

Labels
ACT Issues/Rules related to ACT engine Issues in the accessibility-checker-engine component priority-2 (med) Ready for QA Standards T54 Triage release 5.4
Projects
None yet
Milestone
No milestone
3 participants
@shunguoy @tombrunet @ErickRenteria