fixrule(element_tabbable_visible
): Reduce "Needs review" on custom checkbox and radio buttons
#1848
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixrule(
element_tabbable_visible
) fix the logic related to customer checkbox and radio buttonsPlease review more info: https://github.com/IBMa/equal-access/wiki/Release-notes -->
This PR is related to the following issue(s):
#1610
Additional information can be found here:
Testing reference:
test page: https://cloud.ibm.com/catalog. (need IBM ID to login)
Use the extension filters: Requirements and "Needs Review" only, look at "2.4.7 Focus Visible"
without the fix: approximately 50 "Needs Review" with the message: "Confirm the element should be tabbable, and is visible on the screen when it has keyboard focus"
After the fix: the "Needs Review" with the same message should be gone..
I have conducted the following for this PR: