Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixrule(element_tabbable_visible): Reduce "Needs review" on custom checkbox and radio buttons #1848

Merged
merged 7 commits into from
Mar 11, 2024

Conversation

shunguoy
Copy link
Contributor

@shunguoy shunguoy commented Feb 19, 2024

fixrule(element_tabbable_visible) fix the logic related to customer checkbox and radio buttons

Please review more info: https://github.com/IBMa/equal-access/wiki/Release-notes -->

  • Rule bug: element_tabbable_visible

This PR is related to the following issue(s):

#1610

Additional information can be found here:

Testing reference:

test page: https://cloud.ibm.com/catalog. (need IBM ID to login)
Use the extension filters: Requirements and "Needs Review" only, look at "2.4.7 Focus Visible"
without the fix: approximately 50 "Needs Review" with the message: "Confirm the element should be tabbable, and is visible on the screen when it has keyboard focus"
After the fix: the "Needs Review" with the same message should be gone..

I have conducted the following for this PR:

  • I validated this code in Chrome and FF
  • I validated this fix in my local env
  • I provided details for testing
  • This PR has been reviewed and is ready for test
  • I understand that the title of this PR will be used for the next release notes.

@shunguoy shunguoy changed the title fixrule(element_tabbable_visible) ignore visibility check for Carbon checkbox and radio buttons fixrule(element_tabbable_visible) fix the logic related to customer checkbox and radio buttons Feb 21, 2024
@shunguoy shunguoy requested a review from tombrunet February 21, 2024 15:30
@shunguoy shunguoy marked this pull request as ready for review February 21, 2024 15:30
@philljenkins philljenkins changed the title fixrule(element_tabbable_visible) fix the logic related to customer checkbox and radio buttons fixrule(element_tabbable_visible): Logic to reduce "Needs review" on custom checkbox and radio buttons Feb 22, 2024
@philljenkins philljenkins changed the title fixrule(element_tabbable_visible): Logic to reduce "Needs review" on custom checkbox and radio buttons fixrule(element_tabbable_visible): Reduce "Needs review" on custom checkbox and radio buttons Feb 22, 2024
@ErickRenteria ErickRenteria added this pull request to the merge queue Mar 11, 2024
Merged via the queue into master with commit 23aa10d Mar 11, 2024
15 checks passed
@shunguoy shunguoy deleted the dev-1610 branch March 11, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants