Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit: element_tabbable_visible - can we tighten scope? #1610

Closed
tombrunet opened this issue Aug 29, 2023 · 3 comments
Closed

Revisit: element_tabbable_visible - can we tighten scope? #1610

tombrunet opened this issue Aug 29, 2023 · 3 comments
Assignees
@shunguoy
Labels
engine Issues in the accessibility-checker-engine component priority-3 (low) Ready for QA

Comments

@tombrunet
Copy link
Member

tombrunet commented Aug 29, 2023 •
edited
Loading

This rule fires some "Needs review" items. Can we identify scenarios where this definitely passes so that we can tighten the scope and trigger fewer "Needs Review" items for this.
@tombrunet tombrunet added engine Issues in the accessibility-checker-engine component priority-3 (low) labels Aug 29, 2023
@shunguoy
Copy link
Contributor

https://w3.ibm.com/#/apps/travel

shunguoy added a commit that referenced this issue Feb 16, 2024
@shunguoy
ignore Carbon checkbox and radio buttons #1610
6286139
@shunguoy shunguoy mentioned this issue Feb 19, 2024
Merged
5 tasks
shunguoy added a commit that referenced this issue Feb 19, 2024
@shunguoy
update the rule to ignore carbon checkbox and radio buttons #1610
6390933
shunguoy added a commit that referenced this issue Feb 20, 2024
@shunguoy
update the test results for test cases #1610
c9bf572
shunguoy added a commit that referenced this issue Feb 20, 2024
@shunguoy
update the rules for customer checkbox and radio button #1610
dd6ec67
shunguoy added a commit that referenced this issue Feb 20, 2024
@shunguoy
update the rule comments #1610
8cbb587
@shunguoy shunguoy self-assigned this Feb 21, 2024
@shunguoy
Copy link
Contributor

requested @tombrunet for review.

@drjoho
Copy link
Contributor

drjoho commented Mar 13, 2024

@erick DONE

@drjoho drjoho closed this as completed Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shunguoy shunguoy

Labels
engine Issues in the accessibility-checker-engine component priority-3 (low) Ready for QA
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@shunguoy @tombrunet @drjoho