Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixrule(blockquote_cite_exists): Add cite to messages #1774

Merged
merged 7 commits into from
Dec 13, 2023

Conversation

philljenkins
Copy link
Contributor

@philljenkins philljenkins commented Dec 7, 2023

  • New Rule(s): fixrule(blockquote_cite_exists): Add cite to messages
  • New or modified help files: fixrule(blockquote_cite_exists): Add cite to help

This PR is related to the following issue(s):

Additional information can be found here:

Testing reference:

  • Open dev version of Checker and scan the test case: Blockquote-hasNoCite.html file to trigger rule to see Messages & Help
  • Validate the changes made to rule messages by opening the Action -> Rule listing
  • changed rule message will be listed as:

Needs review — Verify that <blockquote> should have a 'cite' attribute and not be used for indentation only
Use <blockquote> only for quotations, not indentation
RuleID: blockquote_cite_exists
image

I have conducted the following for this PR:

  • I validated this code in Chrome and FF
  • I validated this fix in my local env and using Action artifacts
  • I provided details for testing
  • This PR has been reviewed and is ready for test
  • I understand that the title of this PR will be used for the next release notes.

@philljenkins philljenkins linked an issue Dec 7, 2023 that may be closed by this pull request
remove double negative only
@philljenkins philljenkins marked this pull request as ready for review December 7, 2023 20:25
@philljenkins philljenkins requested a review from shunguoy December 7, 2023 20:25
@ErickRenteria
Copy link
Contributor

@philljenkins can you please provide test results per pr description:
The automated build tests will validate changes made to rule messages, help, and test cases

@philljenkins
Copy link
Contributor Author

philljenkins commented Dec 12, 2023

@ErickRenteria I edited the PR Test Procedure, it now says:

Testing reference:

  • Open dev version of Checker and scan the test case: Blockquote-hasNoCite.html file to trigger rule to see Messages & Help
  • Validate the changes made to rule messages by opening the Action -> Rule listing
  • The changed rule message should be listed as:

RuleID: blockquote_cite_exists Use <blockquote> only for quotations, not indentation
Needs review Verify that <blockquote> should have a 'cite' attribute and not be used for indentation only

@ErickRenteria
Copy link
Contributor

Good to go

@ErickRenteria ErickRenteria merged commit 4d5c2d0 into master Dec 13, 2023
15 checks passed
@shunguoy shunguoy deleted the phill-983-blockquote-cite branch January 29, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update RPT_Blockquote_HasCite rule messages
3 participants