Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RPT_Blockquote_HasCite rule messages #983

Closed
shunguoy opened this issue Jun 17, 2022 · 6 comments · Fixed by #1774
Closed

Update RPT_Blockquote_HasCite rule messages #983

shunguoy opened this issue Jun 17, 2022 · 6 comments · Fixed by #1774
Assignees
Labels
engine Issues in the accessibility-checker-engine component enhancement New feature or request priority-3 (low) Ready for QA SME Discuss with subject matter experts

Comments

@shunguoy
Copy link
Contributor

shunguoy commented Jun 17, 2022

The "RPT_Blockquote_HasCite", renamed to blockquote_cite_exists rule checks if a "blockquote" element has a "cite" attribute or one or more "cite" element(s) as its child(ren). However, the rule messages don't reflect what the rule actually checks:

  `
        "Pass_0": "Rule Passed",
        "Potential_1": "Verify that <blockquote> is used only for quotations, not indentation",
        "group": "Use <blockquote> only for quotations, not indentation"
  ` 

See box note for discussion and proposed changes
blockquote_cite_exists

Will affect the rule logic.ts, help.html, and ruleunit test cases files

@shunguoy shunguoy added engine Issues in the accessibility-checker-engine component enhancement New feature or request labels Jun 17, 2022
@aliunwala aliunwala added the SME Discuss with subject matter experts label Jul 18, 2022
@aliunwala
Copy link
Contributor

aliunwala commented Jul 18, 2022

Triage:
Help/Message do not correctly state what is happening. This needs to be reworded.

The new message will be similar to:
"Verify if blockquote has cite attribute or cite child elements"

The test cases/baselines will need to be updated

@philljenkins
Copy link
Contributor

Current help page for blockquote_cite_exists
image

@philljenkins
Copy link
Contributor

Working on two other higher-priority issues before this one

@philljenkins
Copy link
Contributor

philljenkins commented Dec 5, 2023

Rule was renamed to blockquote_cite_exists.ts
"Potential_1": "Verify that <blockquote> should not be used only for quotations, not indentation",
"group": "Use <blockquote> only for quotations, not indentation"

See box note for discussion and proposed changes
blockquote_cite_exists rule

@philljenkins
Copy link
Contributor

reviewed changes in the team Showcase
image

@philljenkins
Copy link
Contributor

... or child element

was removed from the message and help content since no HTML examples use the <cite> element as children of <blockquote>. All the examples shown are used separately from <blockquote>, so only the attribute is mentioned in the message and help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engine Issues in the accessibility-checker-engine component enhancement New feature or request priority-3 (low) Ready for QA SME Discuss with subject matter experts
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants