Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(extension): Complete dark theme for the browser extension #1493

Merged
merged 28 commits into from
Jun 28, 2023
Merged
Show file tree
Hide file tree
Changes from 24 commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
fd1414c
first attempt at dark mode for 3 panels / modals
drjoho Jun 1, 2023
dfad880
fixed dark mode when you click on issue
drjoho Jun 1, 2023
73a7ed8
add dark mode to many pages
drjoho Jun 2, 2023
773adaf
Dark Mode ready for Design Review
drjoho Jun 6, 2023
534cec6
Special theme for kb visualization guide
drjoho Jun 6, 2023
2f5f0a8
more dark mode
drjoho Jun 9, 2023
54c1919
Quick and User Guide
drjoho Jun 12, 2023
251c721
Store scans button color
drjoho Jun 12, 2023
2147b6f
separating lines right color and size
drjoho Jun 13, 2023
debe0d5
background issues
drjoho Jun 13, 2023
96d5d79
more background fixes
drjoho Jun 13, 2023
90950fc
Fix more backgrounds
drjoho Jun 14, 2023
401de32
Merge branch 'master' into joho-DarkMode-1444
tombrunet Jun 14, 2023
9073bd6
Better Bee
drjoho Jun 15, 2023
70984eb
Better Bee
drjoho Jun 15, 2023
ca28cee
Merge branch 'joho-DarkMode-1444' of https://github.com/IBMa/equal-ac…
drjoho Jun 15, 2023
15a4e1a
backgrounds on guides and options
drjoho Jun 15, 2023
f27f611
fix scan options
drjoho Jun 15, 2023
7a6b93a
background colors
drjoho Jun 15, 2023
65f1913
Menu button sizing
drjoho Jun 15, 2023
8162b7d
Document overflow menu button control
drjoho Jun 19, 2023
ba449a8
color change
drjoho Jun 22, 2023
b1ad281
Update scanSection.scss
drjoho Jun 22, 2023
ee0f082
Merge branch 'master' into joho-DarkMode-1444
drjoho Jun 22, 2023
e4b71a0
Fix Bee icons Light and Dark, Mask group gone
drjoho Jun 24, 2023
a4322e7
Merge branch 'master' into joho-DarkMode-1444
drjoho Jun 28, 2023
a70eb63
Cleanup
drjoho Jun 28, 2023
41f96cf
Merge branch 'master' into joho-DarkMode-1444
ErickRenteria Jun 28, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions accessibility-checker-extension/src/assets/BE_for_DarkMode.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
8 changes: 8 additions & 0 deletions accessibility-checker-extension/src/assets/Mask group.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
9 changes: 9 additions & 0 deletions accessibility-checker-extension/src/assets/Mask group2.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
24 changes: 24 additions & 0 deletions accessibility-checker-extension/src/assets/bee 3 (2).svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
16 changes: 16 additions & 0 deletions accessibility-checker-extension/src/assets/bee 3.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ import React from "react";
import { Column, Grid, Checkbox, Theme } from '@carbon/react';
import { ISettings } from "../../interfaces/interfaces";
import { getBGController } from "../../background/backgroundController";
import { BrowserDetection } from '../../util/browserDetection';

import "./kcmOverviewScreen.scss";

Expand Down Expand Up @@ -49,6 +50,7 @@ export default class KCMOverviewScreen extends React.Component<IKCMOverviewScree
}

render() {
BrowserDetection.setDarkLight();
let showAgainChecked: boolean = this.state.settings ? !this.state.settings?.tabStopAlerts : false;
return <aside className="kcmOverview">
{/* KCM Overview Title */}
Expand Down Expand Up @@ -130,7 +132,7 @@ export default class KCMOverviewScreen extends React.Component<IKCMOverviewScree
</div>
<div style={{clear: "both", marginTop: "1rem"}} />
<div className="iconText">
<Theme theme="g90" className="iconBox">
<Theme theme="g100" className="iconBox">
<KeyboardOff size={16} />
</Theme>
Click on the keyboard icon to return to the regular view.
Expand All @@ -157,6 +159,6 @@ export default class KCMOverviewScreen extends React.Component<IKCMOverviewScree
</div>
</Column>
</Grid>
</aside>;
</aside>
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

.reportSection {
.reportSectionColumn {
border-top: solid $gray-20 1px;
border-top: solid $gray-40 1px;
}
margin-top: 1rem;
.cds--tab-content {
Expand Down Expand Up @@ -58,7 +58,7 @@
}

.reportFilterBorder {
border-top: solid $gray-20 1px;
border-top: solid $gray-40 1px;
}

.reportFilterSection {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -287,8 +287,8 @@ export class ReportSection extends React.Component<ReportSectionProps, ReportSec
inline={true}
onClick={() => {
let appController = getDevtoolsAppController();
appController.setSecondaryView("summary");
appController.openSecondary("totalIssuesCount");
drjoho marked this conversation as resolved.
Show resolved Hide resolved
("summary");
appController.openSecondary("tappController.setSecondaryViewotalIssuesCount");
}}>{totalCount} issues found</Link>
</Column>
</Grid>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@
@include type-style('label-01');
> div { // column
> div { // cell
border-top: solid var(--cds-background) var(--border-width);
border-bottom: solid $gray-30 var(--border-width);
border-top: solid $gray-40 var(--border-width);
border-bottom: solid $gray-40 var(--border-width);
margin: 0rem -1rem;
padding: 0.5rem 0rem .5rem 1rem;
height: 100%;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -569,7 +569,8 @@ export class ReportTreeGrid<RowType extends IRowGroup> extends React.Component<R
let selectedDescendant: boolean = !!this.props.selectedPath
&& thisIssue.path.dom.startsWith(this.props.selectedPath);
let focused: boolean = this.state.tabRowId === rowId
bodyContent.push(<Grid
bodyContent.push(
<Grid
id={rowId}
role="row"
aria-level="2"
Expand All @@ -586,6 +587,7 @@ export class ReportTreeGrid<RowType extends IRowGroup> extends React.Component<R
this.onRow(group, thisIssue);
}}
>

<Column className="gridChild" role="gridcell" aria-selected={selectedIssue} sm={4} md={8} lg={8}>
<div className="gridDataCell">
{UtilIssueReact.valueToIcon(thisIssue.value, "levelIcon")} {thisIssue.message} <a
Expand All @@ -605,7 +607,8 @@ export class ReportTreeGrid<RowType extends IRowGroup> extends React.Component<R
>Learn more</a>
</div>
</Column>
</Grid>);
</Grid>
);
}
}
}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,18 +1,80 @@
@use '@carbon/styles/scss/type'as *;
@use '@carbon/styles/scss/theme'as *;



.cds--overflow-menu-options[aria-label='stored scans'] {
min-width: 12rem;
.cds--overflow-menu-options__btn {
min-width: 12rem;
}
}

.scanSection {
.cds--overflow-menu--sm {
min-height: 2rem;


.cds--g100 {
.scanSection {
.cds--overflow-menu__wrapper {
button {
height: 2rem;
width: 2rem;
background-color: #393939; // color of initial menu button and menu items
// border: 1px solid gray;
min-height: 2rem;
.cds--overflow-menu__icon {
fill: white;
}
.cds--btn--md.cds--btn--icon-only {
padding-right: 0.5rem;
padding-left: 0.5rem;
}
}
}
.cds--overflow-menu.cds--overflow-menu--open:hover {
background-color: #595959; // color of button on hover
}
.cds--overflow-menu.cds--overflow-menu--open {
height: 2rem;
min-height: 2rem;
background-color: #393939; // color of secondary button
.cds--overflow-menu__icon {
fill: white;
}
}
}

}

.cds--white {
.scanSection {
.cds--overflow-menu__wrapper {
button { height: 2rem;
width: 2rem;
min-height: 2rem;
background-color: #e0e0e0; // color of initial menu button and menu items
.cds--overflow-menu__icon {
fill: black;
}
.cds--btn--md.cds--btn--icon-only {
padding-right: 0.5rem;
padding-left: 0.5rem;
}
}
}
.cds--overflow-menu.cds--overflow-menu--open:hover {
background-color: #e0e0e0; // color of button on hover
}
.cds--overflow-menu.cds--overflow-menu--open {
height: 2rem;
min-height: 2rem;
background-color: #e0e0e0; // color of secondary button
.cds--overflow-menu__icon {
fill: black;
}
}
}
}

.scanSection {
.storedCount {
margin-top:.5rem;
@include type-style("label-01");
Expand All @@ -21,4 +83,7 @@
.inlineLoading {
background-color: $layer;
}
}

}


Loading