Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature(extension): Complete dark theme for the browser extension #1493

Merged
merged 28 commits into from
Jun 28, 2023
Merged

feature(extension): Complete dark theme for the browser extension #1493

merged 28 commits into from
Jun 28, 2023

Conversation

drjoho
Copy link
Contributor

@drjoho drjoho commented Jun 14, 2023 •
edited
Loading

Additional information can be found here:

Testing reference:

I have conducted the following for this PR:

  • I validated this code in Chrome and FF
  • I validated this fix in my local env
  • I provided details for testing
  • This PR has been reviewed and is ready for test
  • I understand that the title of this PR will be used for the next release notes.

drjoho and others added 21 commits June 1, 2023 14:01
@drjoho
first attempt at dark mode for 3 panels / modals
fd1414c
@drjoho
fixed dark mode when you click on issue
dfad880
@drjoho
add dark mode to many pages
73a7ed8
@drjoho
Dark Mode ready for Design Review
773adaf
@drjoho
Special theme for kb visualization guide
534cec6
@drjoho
more dark mode
2f5f0a8
@drjoho
Quick and User Guide
54c1919
@drjoho
Store scans button color
251c721
@drjoho
separating lines right color and size
2147b6f
@drjoho
background issues
debe0d5
@drjoho
more background fixes
96d5d79
@drjoho
Fix more backgrounds
90950fc
@tombrunet
Merge branch 'master' into joho-DarkMode-1444
401de32
@drjoho
Better Bee
9073bd6
@drjoho
Better Bee
70984eb
@drjoho
Merge branch 'joho-DarkMode-1444' of https://github.com/IBMa/equal-ac…
ca28cee 
…cess into joho-DarkMode-1444
@drjoho
backgrounds on guides and options
15a4e1a
@drjoho
fix scan options
f27f611
@drjoho
background colors
7a6b93a
@drjoho
Menu button sizing
65f1913
@drjoho
Document overflow menu button control
8162b7d
@drjoho drjoho requested a review from tombrunet June 22, 2023 18:58
@drjoho drjoho marked this pull request as ready for review June 26, 2023 14:53
@drjoho drjoho marked this pull request as draft June 26, 2023 14:54
@drjoho drjoho marked this pull request as ready for review June 26, 2023 14:54
@tombrunet tombrunet changed the title Dark Mode for the Checker feature(extension): Complete dark theme for the browser extension Jun 28, 2023
@ErickRenteria
Copy link
Contributor

Validated

@ErickRenteria ErickRenteria merged commit a46c3fe into master Jun 28, 2023
@tombrunet tombrunet deleted the joho-DarkMode-1444 branch August 15, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tombrunet tombrunet tombrunet left review comments

@ErickRenteria ErickRenteria ErickRenteria approved these changes

Assignees
No one assigned
Labels
Ready for QA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drjoho @ErickRenteria @tombrunet